Skip to content

Conversation

@sandeepkatumalla
Copy link
Contributor

Adding Lots to Consumption RP

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

Adding Lots to Consumption RP
@AutorestCI
Copy link

AutorestCI commented Sep 20, 2018

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@AutorestCI
Copy link

AutorestCI commented Sep 20, 2018

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Sep 20, 2018

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

}
},
"x-ms-pageable": {
"nextLinkNa
Copy link
Contributor Author

@sandeepkatumalla sandeepkatumalla Sep 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots is the only addition to Consumption swagger for ARM review. This will not be checked in. We require swagger ARM sign off to add this to ARM Prod manifest. Please review.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sandeepkatumalla - does this mean you do not intend for this PR to be merged?

I have tagged ARM for review.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, not intending to merge this.

@AutorestCI
Copy link

AutorestCI commented Sep 20, 2018

Automation for azure-sdk-for-ruby

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-ruby#1684

@annatisch annatisch added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 20, 2018
@AutorestCI
Copy link

AutorestCI commented Sep 20, 2018

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#3663

@annatisch
Copy link
Member

Adding @ravbhatnagar for ARM review.

According to @sandeepkatumalla - there is only one new API in the spec to review, as identified by his comment.

@AutorestCI
Copy link

AutorestCI commented Sep 20, 2018

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@annatisch annatisch added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Sep 20, 2018
@vladimirjoanovic vladimirjoanovic added ARMReviewInProgress ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMReviewInProgress WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 21, 2018
Copy link

@vladimirjoanovic vladimirjoanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed with ARM folks and ARM is good with this. approving manifest too.

@annatisch
Copy link
Member

Thanks @vladimirjoanovic

@sandeepkatumalla - Now that it has ARM signoff I will close this PR as per your earlier comments.
Let me know if it needs to be reopened for any reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review DoNotMerge <valid label in PR review process> use to hold merge after approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants