-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Adding Lots to Consumption RP #3977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adding Lots to Consumption RP
Automation for azure-sdk-for-jsNothing to generate for azure-sdk-for-js |
Automation for azure-sdk-for-pythonNothing to generate for azure-sdk-for-python |
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
|
Can one of the admins verify this patch? |
| } | ||
| }, | ||
| "x-ms-pageable": { | ||
| "nextLinkNa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots is the only addition to Consumption swagger for ARM review. This will not be checked in. We require swagger ARM sign off to add this to ARM Prod manifest. Please review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sandeepkatumalla - does this mean you do not intend for this PR to be merged?
I have tagged ARM for review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, not intending to merge this.
Automation for azure-sdk-for-rubyA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-nodeA PR has been created for you: |
|
Adding @ravbhatnagar for ARM review. According to @sandeepkatumalla - there is only one new API in the spec to review, as identified by his comment. |
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
...cation/consumption/resource-manager/Microsoft.Consumption/stable/2018-09-30/consumption.json
Show resolved
Hide resolved
vladimirjoanovic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed with ARM folks and ARM is good with this. approving manifest too.
|
Thanks @vladimirjoanovic @sandeepkatumalla - Now that it has ARM signoff I will close this PR as per your earlier comments. |
Adding Lots to Consumption RP
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger