Fix issue with CI-RpaaSRPNotInPrivateRepo overriding ARMSignedOff#39630
Merged
Fix issue with CI-RpaaSRPNotInPrivateRepo overriding ARMSignedOff#39630
CI-RpaaSRPNotInPrivateRepo overriding ARMSignedOff#39630Conversation
…erly honor RPaaSException in conjunction with CI-RpaaSRPNotInPrivateRepo, but we WERE in conjunction with CI-NewRPNamespaceWithoutRPaaS. due to not honoring that conjunction, we were seeing 'blocked on rpaas' which means we HAD to be not ready for arm review which means we had to remove armsignedoff
Next Steps to MergeNext steps that must be taken to merge this PR:
Comment generated by summarize-checks workflow run. |
mikeharder
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #39561
@mikeharder this ended up being more explicable than I originally thought - the PR changes will pretty much immediately reveal the issue.
When we are processing the arm workflow labels, like
NotReadyForArmRevieworArmSignedOff, we evaluate the impact assessment to know if we're READY to go through the review.You're by definition NOT ready for ARM review if you have
blocked on RPaaSwhich is one of two possible blockers from RPaaS:CI-NewRPNamespaceWithoutRPaaSCI-RpaaSRPNotInPrivateRepoBoth of these situations should honor
RPaaSException. As you can see by the code change, it WASN'T honoring the exception for the latter case. As a result, we were applyingNotReadyForArmReview, which resulted in the removal ofArmSignedOff.