swagger change for application gateway waf global config and exclusio…#3962
swagger change for application gateway waf global config and exclusio…#3962azhao155 wants to merge 2 commits intoAzure:masterfrom
Conversation
Automation for azure-sdk-for-jsNothing to generate for azure-sdk-for-js |
|
Can one of the admins verify this patch? |
Automation for azure-sdk-for-rubyA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-pythonA PR has been created for you: |
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
Automation for azure-sdk-for-goA PR has been created for you: |
Automation for azure-sdk-for-nodeA PR has been created for you: |
|
@azhao155 why do you push it to |
|
@MikhailTryakhov the change is already in nrp api version 2018-08-01, so we want to add to the same version here, also, what branch do you think i need to push? This is for the ignite. |
|
@allanbomsft could you take a look at this as well? |
There was a problem hiding this comment.
This is hard to understand and not very helpful. Perhaps more something like this: "When matchVariable is a collection, serlector is used to specify which elements in the collection this exclusion applies to"
There was a problem hiding this comment.
This is hard to understand and not very helpful. Perhaps more something like this: "Operator used to control how matchVariable matches this exclusion entry". I don't fully remember the options here, so maybe I'm mistaking.
| "description": "The variable to be excluded." | ||
| }, | ||
| "selectorMatchOperator": { | ||
| "type": "string", |
There was a problem hiding this comment.
How far down in the stack are these strings vs. enums? If they were enums here, I think the auto generated API's will have built in validation and auto-completion, so we should consider the tradeoffs of enums vs strings here.
There was a problem hiding this comment.
we have string defination on the nrp and also have validation there, so don't want to make the transfer in the nrp code. It will be too long for us.
| "format": "int32", | ||
| "maximum": 128, | ||
| "exclusiveMaximum": false, | ||
| "minimum": 8, |
There was a problem hiding this comment.
Isn't minimum value of the maxRequeustBodySizeInKb supposed to 1KB?
| "fileUploadLimitInMb": { | ||
| "type": "integer", | ||
| "format": "int32", | ||
| "maximum": 500, |
There was a problem hiding this comment.
For the fileUploadLimitInMb there seem to be two different values:
MaxFileUploadSizeInMbForMediumGw and MaxFileUploadSizeInMbForLargeGw, shouldn't we have these as different limits in the swagger as well?
|
@MikhailTryakhov should it be network-october-release |
sergey-shandar
added
the
WaitForARMFeedback
| "description": "Allows to disable rules within a rule group or an entire rule group." | ||
| }, | ||
| "ApplicationGatewayFirewallExclusion": { | ||
| "properties": { |
There was a problem hiding this comment.
when i tested i noticed it was like this
"exclusions": [
{
"matchVariable": "RequestCookieNames",
"selectorMatchOperator": "Contains",
"selector": "hello"
}
]
There was no "properties" : {}. So is this correct?
|
@azhao155 @sergey-shandar is this PR abandoned? |
7 participants
…n list
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger