Moving latest stable API version from private repo to public repo#39553
Moving latest stable API version from private repo to public repo#39553rsinghal26 wants to merge 7 commits intoAzure:mainfrom
Conversation
Next Steps to MergeNext steps that must be taken to merge this PR:
Comment generated by summarize-checks workflow run. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
…ails and generation options
|
We are moving stable API version from private repo to stable repo because informatica is a GA service. all the breaking changes are already approved in below PRs: 2024-11-29-preview: Adding marketplaceSubscriptionStatus field for informatica by kanika-ms · Pull Request #20488 · Azure/azure-rest-api-specs-pr 2024-07-22-preview: Liftr Informatica API - preview version release 2024-07-22 by almasak · Pull Request #18953 · Azure/azure-rest-api-specs-pr We have not added any new change compared with what we have in private spec repo in latest version 2025-11-27. |
Looks like this suppression should be addressed. Refers to: specification/informatica/Informatica.DataManagement.Management/main.tsp:535 in 5326229. [](commit_id = 5326229, deletion_comment = False) |
|
@rsinghal26 - Thank-you for providing links to the earlier specs in the private repo. This helps cut down on the reviewer's workload. Couple of things to check:
|
|
@mentat9, thanks for the review this PR. I updated the namespace in the examples. |
| - "@azure-tools/typespec-azure-rulesets/resource-manager" | ||
| parameters: | ||
| service-dir: | ||
| default: sdk/placeholder #!!!IMPORTANT!!! To ensure the emitter correctly produces SDK, this configuration is added by Azure SDK Team. Some configurations use placeholder values. For modifications, please refer to https://aka.ms/azsdk/specs/typespec-validation#sdktspconfigvalidation |
| generate-test: true #!!!IMPORTANT!!! To ensure the emitter correctly produces SDK, this configuration is added by Azure SDK Team. Some configurations use placeholder values. For modifications, please refer to https://aka.ms/azsdk/specs/typespec-validation#sdktspconfigvalidation | ||
| generate-sample: true #!!!IMPORTANT!!! To ensure the emitter correctly produces SDK, this configuration is added by Azure SDK Team. Some configurations use placeholder values. For modifications, please refer to https://aka.ms/azsdk/specs/typespec-validation#sdktspconfigvalidation | ||
| experimental-extensible-enums: true #!!!IMPORTANT!!! To ensure the emitter correctly produces SDK, this configuration is added by Azure SDK Team. Some configurations use placeholder values. For modifications, please refer to https://aka.ms/azsdk/specs/typespec-validation#sdktspconfigvalidation | ||
| linter: |
| options: | ||
| "@azure-tools/typespec-autorest": | ||
| use-read-only-status-schema: true | ||
| emitter-output-dir: "{project-root}/.." |
There was a problem hiding this comment.
Removed emit-common-types-schema: "never"?
| } | ||
| ], | ||
| "nextLink": "tjhcbb" | ||
| "nextLink": "https://management.azure.com/providers/Informatica.DataManagement/operations?api-version=2024-07-22-preview&$skiptoken=eyJpZCI6ImVmemV3aG5rcGhsdGFhanBibW1tcG1reGNpZXFpIiwib3JpZ2luIjoiYXJ0aWNsZSIsInJlc291cmNlIjoieHZteHRjdHFsd3N1Z3ZxYmF1b3duYWx3cGppIn0=" |
| }, | ||
| "body": { | ||
| "id": "cadokiejnrth", | ||
| "id": "/subscriptions/A0A3E464-6AA7-42BC-9EF1-65840CB55277/resourceGroups/rgopenapi/providers/Informatica.DataManagement/organizations/C", |
| "202": { | ||
| "headers": { | ||
| "id": "cadokiejnrth", | ||
| "id": "https://management.azure.com/providers/Informatica.DataManagement/operations?api-version=2024-07-22-preview&$skiptoken=eyJpZCI6ImVmemV3aG5rcGhsdGFhanBibW1tcG1reGNpZXFpIiwib3JpZ2luIjoiYXJ0aWNsZSIsInJlc291cmNlIjoieHZteHRjdHFsd3N1Z3ZxYmF1b3duYWx3cGppIn0=", |
There was a problem hiding this comment.
| "subscriptionId": "zl", | ||
| "region": "lrudpuvzcuh", | ||
| "serverlessArmResourceId": "/subscriptions/subid/resourceGroups/rg1/providers/Informatica.DataManagement/organizations/org1/serverlessRuntimes/serverlessRuntimeName" | ||
| "serverlessArmResourceId": "/subscriptions/A0A3E464-6AA7-42BC-9EF1-65840CB55277/resourceGroups/rgopenapi/providers/Informatica.DataManagement/organizations/C" |
| "executionTimeout": "pbnxiricrjifreoiazmzeqiwu", | ||
| "computeUnits": "ao", | ||
| "tenantId": "00000000-0000-0000-0000-000000000000", | ||
| "tenantId": "elbephnucclhjihcj", |
| "organizationName": "nomzbvwe", | ||
| "informaticaRegion": "zfqodqpbeflhedypiijdkc", | ||
| "singleSignOnUrl": "https://contoso.com/singlesignon" | ||
| "singleSignOnUrl": "https://microsoft.com/a" |
There was a problem hiding this comment.
"singleSignOnUrl": "https://microsoft.com/a"
Why this change?
| }, | ||
| "location": "pamjoudtssthlbhrnfjidr", | ||
| "id": "cadokiejnrth", | ||
| "id": "/subscriptions/A0A3E464-6AA7-42BC-9EF1-65840CB55277/resourceGroups/rgopenapi/providers/Informatica.DataManagement/organizations/C", |
| "200": { | ||
| "body": { | ||
| "id": "cadokiejnrth", | ||
| "id": "/subscriptions/A0A3E464-6AA7-42BC-9EF1-65840CB55277/resourceGroups/rgopenapi/providers/Informatica.DataManagement/organizations/C", |
| "organizationName": "nomzbvwe", | ||
| "informaticaRegion": "zfqodqpbeflhedypiijdkc", | ||
| "singleSignOnUrl": "https://contoso.com/singlesignon" | ||
| "singleSignOnUrl": "https://microsoft.com/a" |
There was a problem hiding this comment.
singleSignOnUrl": "https://microsoft.com/a"
why this change?
| }, | ||
| "location": "pamjoudtssthlbhrnfjidr", | ||
| "id": "cadokiejnrth", | ||
| "id": "/subscriptions/A0A3E464-6AA7-42BC-9EF1-65840CB55277/resourceGroups/rgopenapi/providers/Informatica.DataManagement/organizations/C", |
Any reason why this string is this long? Refers to: specification/informatica/Informatica.DataManagement.Management/examples/2024-05-08/Organizations_ListByResourceGroup_MaximumSet_Gen.json:30 in 834393b. [](commit_id = 834393b, deletion_comment = False) |
| "id": "cadokiejnrth", | ||
| "id": "/subscriptions/A0A3E464-6AA7-42BC-9EF1-65840CB55277/resourceGroups/rgopenapi/providers/Informatica.DataManagement/organizations/C", | ||
| "name": "qmlpllxohjomejbeylyhlqwt", | ||
| "type": "korjyotq", |
| "vnetId": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/virtualNetworks/HypernetVnet1", | ||
| "subnetId": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Networks/virtualNetworks/test-vnet/subnets/subnet1", | ||
| "vnetId": "/subscriptions/A0A3E464-6AA7-42BC-9EF1-65840CB55277/resourceGroups/rgopenapi/providers/Informatica.DataManagement/organizations/C", | ||
| "subnetId": "/subscriptions/A0A3E464-6AA7-42BC-9EF1-65840CB55277/resourceGroups/rgopenapi/providers/Informatica.DataManagement/organizations/C", |
There was a problem hiding this comment.
These are not vnet or subnet ids
| "vnetId": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/virtualNetworks/HypernetVnet1", | ||
| "subnetId": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Networks/virtualNetworks/test-vnet/subnets/subnet1", | ||
| "vnetId": "/subscriptions/A0A3E464-6AA7-42BC-9EF1-65840CB55277/resourceGroups/rgopenapi/providers/Informatica.DataManagement/organizations/C", | ||
| "subnetId": "/subscriptions/A0A3E464-6AA7-42BC-9EF1-65840CB55277/resourceGroups/rgopenapi/providers/Informatica.DataManagement/organizations/C", |
| }, | ||
| "id": "/subscriptions/A0A3E464-6AA7-42BC-9EF1-65840CB55277/resourceGroups/rgopenapi/providers/Informatica.DataManagement/organizations/C", | ||
| "name": "byzccgftqjthb", | ||
| "type": "due", |
| } | ||
| } | ||
| } | ||
| }, |
There was a problem hiding this comment.
Why this change in an older API version?
| "parameters": [ | ||
| { | ||
| "$ref": "../../../../../common-types/resource-management/v3/types.json#/parameters/ApiVersionParameter" | ||
| "$ref": "../../../../../common-types/resource-management/v5/types.json#/parameters/ApiVersionParameter" |
There was a problem hiding this comment.
As per offline discussion, no customer is using this API version through portal or client SDK, the change being made here is to be consistent with the API version spec in private repo.
This PR is introducing a breaking change that was previously approved in private repo, which shouldn't have been done IMO.
Because there are no users for this API version I'm approving this breaking change for an already released API version to maintain parity with private repo spec
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PRandDue diligence checklist.write accessper aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.