Skip to content

[ApiManagement] Added missing 202 Accepted response code #3952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anuchandy merged 4 commits into from
Sep 19, 2018
Merged

[ApiManagement] Added missing 202 Accepted response code #3952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
56fd59c
Added missing 202 Accepted response code to Api Management
torresdal Sep 19, 2018
4c9523d
Updated example for Api Management Service using response code 202
torresdal Sep 19, 2018
18f46c6
Updated example for Api Management Service MSI using response code 202
torresdal Sep 19, 2018
1c708b2
Updated example for Api Management Service with Custom Hostname using…
torresdal Sep 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ...management/resource-manager/Microsoft.ApiManagement/stable/2017-03-01/apimdeployment.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,12 @@
"schema": {
"$ref": "#/definitions/ApiManagementServiceResource"
}
},
"202": {
"description": "Accepted",
"schema": {
"$ref": "#/definitions/ApiManagementServiceResource"
}
Copy link
Member

@anuchandy anuchandy Sep 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@torresdal can you update the example for ApiManagementService_CreateOrUpdate to have 202 response as well?

Copy link
Contributor Author

@torresdal torresdal Sep 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anuchandy I added 202 to the examples listed under x-ms-examples. All good?

}
},
"x-ms-long-running-operation": true
Expand Down Expand Up @@ -1389,4 +1395,4 @@
}
},
"parameters": {}
}
}
83 changes: 81 additions & 2 deletions ...t/stable/2017-03-01/examples/ApiManagementCreateMultiRegionServiceWithCustomHostname.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"resourceGroupName": "rg1",
"api-version": "2017-03-01",
"subscriptionId": "subid",
"parameters": {
"parameters": {
"location": "Central US",
"sku": {
"name": "Premium",
Expand Down Expand Up @@ -206,6 +206,85 @@
"capacity": 1
}
}
},
"202": {
"body": {
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.ApiManagement/service/apimService1",
"name": "apimService1",
"type": "Microsoft.ApiManagement/service",
"tags": {},
"location": "Central US",
"etag": "AAAAAAAXXwI=",
"properties": {
"publisherEmail": "admin@live.com",
"publisherName": "contoso",
"provisioningState": "Succeeded",
"targetProvisioningState": "",
"createdAtUtc": "2017-05-30T19:00:47.1121713Z",
"gatewayUrl": "https://apimService1.azure-api.net",
"portalUrl": "https://apimService1.portal.azure-api.net",
"managementApiUrl": "https://apimService1.management.azure-api.net",
"scmUrl": "https://apimService1.scm.azure-api.net",
"hostnameConfigurations": [
{
"type": "Proxy",
"hostName": "proxyhostname1.contoso.com",
"negotiateClientCertificate": false,
"certificate": {
"expiry": "2018-03-17T21:55:07+00:00",
"thumbprint": "918D7785B926AC5AEE66322778A147BCE7237CF3",
"subject": "CN=proxyhostname1.contoso.com"
}
},
{
"type": "Proxy",
"hostName": "proxyhostname2.contoso.com",
"negotiateClientCertificate": true,
"certificate": {
"expiry": "2018-03-17T21:55:07+00:00",
"thumbprint": "918D7785B926AC5AEE66322778A147BCE7237CF3",
"subject": "CN=proxyhostname2.contoso.com"
}
},
{
"type": "Portal",
"hostName": "portalhostname1.contoso.com",
"negotiateClientCertificate": false,
"certificate": {
"expiry": "2018-03-17T21:55:07+00:00",
"thumbprint": "918D7785B926AC5AEE66322778A147BCE7237CF3",
"subject": "CN=portalhostname1.contoso.com"
}
}
],
"staticIps": [
"52.173.193.207"
],
"additionalLocations": [
{
"location": "West US",
"sku": {
"name": "Premium",
"capacity": 1
},
"staticIps": [
"104.210.41.234"
],
"virtualNetworkConfiguration": {
"subnetResourceId": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/virtualNetworks/westUsVirtualNetwork/subnets/apimSubnet"
}
}
],
"virtualNetworkConfiguration": {
"subnetResourceId": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/virtualNetworks/centralUsVirtualNetwork/subnets/apimSubnet"
},
"virtualNetworkType": "External"
},
"sku": {
"name": "Premium",
"capacity": 1
}
}
}
}
}
}
31 changes: 30 additions & 1 deletion ...anager/Microsoft.ApiManagement/stable/2017-03-01/examples/ApiManagementCreateService.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,35 @@
"capacity": 1
}
}
},
"202": {
"body": {
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.ApiManagement/service/apimService1",
"name": "apimService1",
"type": "Microsoft.ApiManagement/service",
"tags": {},
"location": "West US",
"etag": "AAAAAAAV8XM=",
"properties": {
"publisherEmail": "admin@live.com",
"publisherName": "Contoso",
"provisioningState": "Succeeded",
"targetProvisioningState": "",
"createdAtUtc": "2015-09-22T01:52:02.4307221Z",
"gatewayUrl": "https://apimService1.azure-api.net",
"portalUrl": "https://apimService1.portal.azure-api.net",
"managementApiUrl": "https://apimService1.management.azure-api.net",
"scmUrl": "https://apimService1.scm.azure-api.net",
"staticIps": [
"xx.xx.250.222"
],
"virtualNetworkType": "None"
},
"sku": {
"name": "Premium",
"capacity": 1
}
}
}
}
}
}
31 changes: 30 additions & 1 deletion ...crosoft.ApiManagement/stable/2017-03-01/examples/ApiManagementCreateServiceHavingMsi.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,35 @@
"tenantId": "72f988bf-xxxx-41af-xxxx-2d7cd011db47"
}
}
},
"202": {
"headers": {
"location": "https://management.azure.com/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.ApiManagement/service/apimService1/operationresults/dGVjaGVkX01hbmFnZVJvbGVfNWRiNGI3Ng==?api-version=2017-03-01"
},
"body": {
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.ApiManagement/service/apimService1",
"name": "apimService1",
"type": "Microsoft.ApiManagement/service",
"location": "Japan East",
"etag": "AAAAAAC268k=",
"properties": {
"publisherEmail": "admin@contoso.com",
"publisherName": "Contoso",
"notificationSenderEmail": "apimgmt-noreply@mail.windowsazure.com",
"provisioningState": "Created",
"targetProvisioningState": "Activating",
"createdAtUtc": "2017-10-27T23:41:41.7231779Z"
},
"sku": {
"name": "Developer",
"capacity": 1
},
"identity": {
"type": "SystemAssigned",
"principalId": "f4b0f1c2-xxxx-43db-xxxx-ccd99e1afd22",
"tenantId": "72f988bf-xxxx-41af-xxxx-2d7cd011db47"
}
}
}
}
}
}