Update Azure metrics data plane swagger to address few doc generation bugs#3945
Merged
hovsepm merged 21 commits intoAzure:masterfrom Sep 18, 2018
Merged
Update Azure metrics data plane swagger to address few doc generation bugs#3945hovsepm merged 21 commits intoAzure:masterfrom
hovsepm merged 21 commits intoAzure:masterfrom
Conversation
- Use a shorter operationId - Remove any non-success response code with default response clause - Add a new example and reference it in the swagger spec - Include readme.md file for the swagger spec
- Inline the readme.python.md file in the readme.md
…sible names instead
- Fix the readme.md naming incompatibilities - Remove the c#-ish namespace prefix
-Rename bunch of properties to follow camel case naming -Update the enum types to have the "x-ms-enum" part of the json
-Update path and namespace for Java section
…imple object type instead. This should make the swagger spec clean and more easily maintainable in the long run
# Conflicts: # specification/monitor/data-plane/readme.md
-Rename the file to be consistent with operationId
-Update the readme reference of the swagger spec -Include required fields for more swagger items as applicable -Escape the backslash and add backslash for audience in header
…pecs # Conflicts: # specification/monitor/data-plane/preview/2018-09-01-preview/MetricsCreate.json # specification/monitor/data-plane/preview/2018-09-01-preview/MetricsCreate_API.json # specification/monitor/data-plane/preview/2018-09-01-preview/azureMonitorCustomMetricsIngestionApi.json # specification/monitor/data-plane/readme.md
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-jsNothing to generate for azure-sdk-for-js |
Contributor
|
Can one of the admins verify this patch? |
Contributor
|
@vickyv51 please add human readable description with short summary of the change. e.g. why do you need to change the name of the swagger? |
Contributor
Author
|
Make following changes to Azure metrics data plane api spec to improve the generated doc spec |
hovsepm
approved these changes
Sep 18, 2018
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-nodeNothing to generate for azure-sdk-for-node |
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
This was referenced Sep 18, 2018
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
mccleanp
pushed a commit
that referenced
this pull request
Mar 23, 2022
* Generate 2021-06-01 api only * Fix ruby * Fix C# Co-authored-by: Shuo Li <shul@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make following changes to Azure metrics data plane api spec to improve the generated doc spec
-Use consistent naming "xyz_API" for the swagger spec file. (xyz=metricsCreate)
-Update the readme reference of the swagger spec
-Include required fields for more swagger items as applicable
-Escape the backslash and add backslash for audience in header