Skip to content

Conversation

@akrabi
Copy link
Contributor

@akrabi akrabi commented Dec 28, 2025

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
  • A release plan has been created. If not, please create one as it will help guide you through the REST API and SDK creation process.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.
  • For guidance on SDK breaking change review, refer to https://aka.ms/ci-fix.

@github-actions
Copy link

github-actions bot commented Dec 28, 2025

Next Steps to Merge

Important checks have failed. As of today they are not blocking this PR, but in near future they may.
Addressing the following failures is highly recommended:
  • ⚠️ The check named Swagger BreakingChange has failed. To unblock this PR, follow the process at aka.ms/brch.
If you still want to proceed merging this PR without addressing the above failures, refer to step 4 in the PR workflow diagram.

Comment generated by summarize-checks workflow run.

@akrabi akrabi requested a review from salambashir December 28, 2025 10:47
@github-actions github-actions bot added brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. resource-manager labels Dec 28, 2025
@akrabi akrabi marked this pull request as ready for review December 28, 2025 10:50
@github-actions github-actions bot added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 28, 2025
Copy link
Member

@salambashir salambashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akrabi akrabi changed the title Assafak/add df sv2 files on demand Microsoft.Security/defenderForStorageSettings[2025-09-01-preview] Dec 28, 2025
@github-actions
Copy link

github-actions bot commented Dec 28, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Java com.azure.resourcemanager:azure-resourcemanager-security
Go sdk/resourcemanager/security/armsecurity
JavaScript @azure/arm-security
Python azure-mgmt-security

@ravimeda
Copy link
Member

Please address the failing checks (Swagger Avocado).

@github-actions github-actions bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 29, 2025
@kazrael2119
Copy link
Member

please resolve duplicate operation issue
image
to fix sdk generation failure

@qiaozha
Copy link
Member

qiaozha commented Dec 30, 2025

Temporally suppress the Avocado Multiple API version failures, will reach out for this to Security team later.

@akrabi
Copy link
Contributor Author

akrabi commented Dec 30, 2025

please resolve duplicate operation issue image to fix sdk generation failure

@kazrael2119 fixed

@akrabi
Copy link
Contributor Author

akrabi commented Dec 30, 2025

Please address the failing checks (Swagger Avocado).

@ravimeda please see @qiaozha's reply

@akrabi akrabi added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 30, 2025
@github-actions github-actions bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 30, 2025
@akrabi akrabi added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMChangesRequested labels Dec 30, 2025
@ravimeda ravimeda added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Dec 31, 2025
@github-actions github-actions bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 31, 2025
@akrabi akrabi merged commit 2455df6 into Azure:release-defenderforstoragesettings/2025-09-01-preview Jan 1, 2026
71 of 75 checks passed
akrabi added a commit that referenced this pull request Jan 6, 2026
…9396) (#39424)

* Add previous version - to be edited in the following commit

* Add defenderForStorageSettings 2025-09-01-preview

* Add operations

* Remove duplicate operations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved-Avocado ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. resource-manager

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants