Microsoft.Security/securityConnectors preview api 2026-01-01-preview#39375
Microsoft.Security/securityConnectors preview api 2026-01-01-preview#39375Anismograbi7 wants to merge 22 commits intomainfrom
Conversation
Next Steps to MergeNext steps that must be taken to merge this PR:
Comment generated by summarize-checks workflow run. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
|
Please address the required checks that are failing. |
|
All active Azure services must convert to TypeSpec by March 31, 2026. Starting July 1, 2026, SDK generation from the autorest toolchain will be blocked. Please reach out tspconversion@service.microsoft.com for TypeSpec conversion support. |
There was a problem hiding this comment.
Approved - this PR is a simple api-version update and will be included in the migration to TypeSpec - please allow this change since the api definitions are correct.
Regarding avocado exception - same as #39058 - we'll resolve these post TypeSpec migration
|
@Anismograbi7 - Please address the Avocado error and the Prettier check failure before ARM review. |
Hey @mentat9 |
|
@mentat9 - to avoid unnecessary conflicts with the typespec migration efforts, we'll be adding this content post migration to typespec (this new version will be added after we complete the typespec migration so avocado and prettier automated checks won't be fixed in this pr - if needed, I can update the typespec PR to include these changes, I wanted to avoid mixing the migration and adding a new api version in the same PR |
|
Is the avocado error new with this PR or has it failed before with previous PR's and have sign off provided then? Also prettier check should not be failing. you need to investigate why its failing. |
…osoft.Security/preview/2026-01-01-preview/securityConnectors.json
|
Hello @psah434 |
|
please fix this avocado error, it has notthing to do with typespec migration, everytime new api version need to update readme correctly. Please see https://github.com/Azure/avocado/blob/master/README.md#MULTIPLE_API_VERSION on how to fix this error. |
|
@Anismograbi7 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PRandDue diligence checklist.write accessper aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.