Fix the Azure metrics data-plane api swagger spec to ensure the documentaiton generation works as expected#3911
Merged
jhendrixMSFT merged 17 commits intoAzure:masterfrom Sep 14, 2018
Merged
Conversation
- Use a shorter operationId - Remove any non-success response code with default response clause - Add a new example and reference it in the swagger spec - Include readme.md file for the swagger spec
- Inline the readme.python.md file in the readme.md
…sible names instead
- Fix the readme.md naming incompatibilities - Remove the c#-ish namespace prefix
-Rename bunch of properties to follow camel case naming -Update the enum types to have the "x-ms-enum" part of the json
-Update path and namespace for Java section
…imple object type instead. This should make the swagger spec clean and more easily maintainable in the long run
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-nodeNothing to generate for azure-sdk-for-node |
Automation for azure-sdk-for-javaThe initial PR has been merged into your service PR: |
# Conflicts: # specification/monitor/data-plane/readme.md
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
Contributor
|
Can one of the admins verify this patch? |
vickyv51
changed the title
jhendrixMSFT
requested changes
Sep 14, 2018
specification/monitor/data-plane/preview/2018-09-01-preview/MetricsPost_API.json
Outdated
Show resolved
Hide resolved
specification/monitor/data-plane/preview/2018-09-01-preview/MetricsPost_API.json
Show resolved
Hide resolved
-Rename the file to be consistent with operationId
jhendrixMSFT
approved these changes
Sep 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger