Skip to content

Protection intent changes and bug fixes#3909

Merged
anuchandy merged 5 commits intoAzure:masterfrom
AdityaTulasi-xx:master
Sep 29, 2018
Merged

Protection intent changes and bug fixes#3909
anuchandy merged 5 commits intoAzure:masterfrom
AdityaTulasi-xx:master

Conversation

@AdityaTulasi-xx
Copy link
Contributor

@AdityaTulasi-xx AdityaTulasi-xx commented Sep 14, 2018

  • Added protection intent API's.
  • Fixed documentation for a few classes.

@AutorestCI AutorestCI mentioned this pull request Sep 14, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Sep 14, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2945

@AutorestCI AutorestCI mentioned this pull request Sep 14, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Sep 14, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-ruby#1645

@AutorestCI
Copy link

AutorestCI commented Sep 14, 2018 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI AutorestCI mentioned this pull request Sep 14, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Sep 14, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3735

@AutorestCI
Copy link

AutorestCI commented Sep 14, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2868

@AutorestCI AutorestCI mentioned this pull request Sep 14, 2018
Closed
@azuresdkci
Copy link
Contributor

azuresdkci commented Sep 14, 2018

Can one of the admins verify this patch?

anuchandy
anuchandy reviewed Sep 17, 2018
View reviewed changes
azure-rest-api-specs.njsproj Outdated
<ProjectTypeGuids>{3AF33F2E-1136-4D97-BBB7-1795711AC8B8};{349c5851-65df-11da-9384-00065b846f21};{9092AA53-FB77-4645-B42D-1CCCA6BD08BD}</ProjectTypeGuids>
<VisualStudioVersion Condition="'$(VisualStudioVersion)' == ''">14.0</VisualStudioVersion>
<VSToolsPath Condition="'$(VSToolsPath)' == ''">$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)</VSToolsPath>
<LastActiveSolutionConfig>Debug|Any CPU</LastActiveSolutionConfig>
Copy link
Member

@anuchandy anuchandy Sep 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert all the changes in this file.

@anuchandy anuchandy added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 17, 2018
@anuchandy
Copy link
Member

anuchandy commented Sep 17, 2018

@ravbhatnagar please review, addition to new apis to stable api-version.

@hovsepm hovsepm added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 17, 2018
@anuchandy anuchandy mentioned this pull request Sep 18, 2018
Open
@AutorestCI AutorestCI mentioned this pull request Sep 18, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Sep 27, 2018 •
edited
Loading

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@AutorestCI AutorestCI mentioned this pull request Sep 27, 2018
Merged
ryansbenson
ryansbenson approved these changes Sep 27, 2018
View reviewed changes
Copy link
Contributor

@ryansbenson ryansbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with agreed upon changes in the next iteration

@ryansbenson ryansbenson added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMReviewInProgress WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 27, 2018
@anuchandy anuchandy mentioned this pull request Sep 28, 2018
Open
@anuchandy anuchandy merged commit cc83d64 into Azure:master Sep 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vladimirjoanovic vladimirjoanovic vladimirjoanovic left review comments

@anuchandy anuchandy anuchandy approved these changes

@ryansbenson ryansbenson ryansbenson approved these changes

@ravbhatnagar ravbhatnagar Awaiting requested review from ravbhatnagar

+1 more reviewer

@DheerendraRathor DheerendraRathor DheerendraRathor left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@anuchandy anuchandy

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review potential-sdk-breaking-change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@AdityaTulasi-xx @AutorestCI @azuresdkci @anuchandy @DheerendraRathor @vladimirjoanovic @ryansbenson @hovsepm