Fix incorrect url and clarify subscription-level disable (unsure why this came with so many commits)#3886
Merged
sergey-shandar merged 33 commits intoAzure:masterfrom Sep 13, 2018
asinn826:master
Merged
Fix incorrect url and clarify subscription-level disable (unsure why this came with so many commits)#3886sergey-shandar merged 33 commits intoAzure:masterfrom asinn826:master
sergey-shandar merged 33 commits intoAzure:masterfrom
asinn826:master
Conversation
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-nodeNothing to generate for azure-sdk-for-node |
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
Contributor
|
Can one of the admins verify this patch? |
Member
|
@sergey-shandar giving it to you, since it seems you have context. |
Contributor
|
@asinn826 why are we introducing breaking changes in the stable API? |
Contributor
|
Given the invalid URIs that existed in the prior version, I'm assuming this is a case where Swagger deviated from the implementation? If this is simply a case of fixing an invalid swagger spec, signing off from ARM. |
sergey-shandar
approved these changes
Sep 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR seems to contain all the changes that were approved and merged in this earlier PR: #3498
2 extra changes on top of those are commits ddf58c3 and 90ad551- both minor. Not sure why this is so big. @sergey-shandar , are you able to help me with this one?
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger