Swagger Changes to Add DnsZonePartner and Collation into Managed Instance #3875

ziwa-msft · 2018-09-12T01:51:00Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

[ x] The title of the PR is clear and informative.
[x ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[x ] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[x ] If applicable, the PR references the bug/issue that it fixes.
[x ] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
[ x] My spec meets the review criteria:
- [x ] The spec conforms to the Swagger 2.0 specification.
- [ x] The spec follows the guidelines described in the Swagger checklist document.
- [x ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

…specs

azuresdkci · 2018-09-12T01:51:53Z

Can one of the admins verify this patch?

AutorestCI · 2018-09-12T01:52:49Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2671

AutorestCI · 2018-09-12T01:53:03Z

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1562

AutorestCI · 2018-09-12T01:54:13Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

AutorestCI · 2018-09-12T01:56:09Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2738

AutorestCI · 2018-09-12T02:06:04Z

Automation for azure-sdk-for-node

Encountered a Subprocess error: (azure-sdk-for-node)

Command: ['/usr/local/bin/autorest', '/tmp/tmpu78ps76g/rest/specification/sql/resource-manager/readme.md', '--license-header=MICROSOFT_MIT_NO_VERSION', '--node-sdks-folder=/tmp/tmpu78ps76g/sdk', '--nodejs', '[email protected]/[email protected]']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.11.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4283)
   Loading AutoRest extension '@microsoft.azure/autorest.nodejs' (2.1.103->2.1.103)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Shutting Down
Shutting Down
FATAL: nodejs/generate - FAILED
FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.nodejs' terminated.
Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.nodejs' terminated.

jaredmoo · 2018-09-12T04:14:07Z

...urce-manager/Microsoft.Sql/preview/2015-05-01-preview/examples/ManagedInstanceCreateMax.json

          "subnetId" : "/subscriptions/20D7082A-0FC7-4468-82BD-542694D5042B/resourceGroups/testrg/providers/Microsoft.Network/virtualNetworks/vnet1/subnets/subnet1",
-          "state" : "Ready"
+          "state": "Ready",
+          "dnsZone":  "1b4e2caff2530"


Is this a realistic-looking dns zone?

Yes it is. We generate dns zone with the first part of a new Guid.

jaredmoo · 2018-09-12T04:14:43Z

.../resource-manager/Microsoft.Sql/preview/2015-05-01-preview/examples/ManagedInstanceList.json

              "storageSizeInGB": 1024,
-              "licenseType": "Full"
+              "licenseType": "Full",
+              "collation":  "SQL_Latin1_General_CP1_CI_AS"


Looks like dnsZone is missing from all these other examples

Will address this now

jaredmoo · 2018-09-12T04:15:27Z

...fication/sql/resource-manager/Microsoft.Sql/preview/2015-05-01-preview/managedInstances.json

+        "collation": {
+          "description": "Collation of the managed instance.",
+          "type": "string",
+          "x-ms-mutability": [


I thought this was made readonly now

Yes, the Collation property is made read-only a three weeks ago. Mike, which sync point you've used for generating the swagger changes?

jaredmoo

Minor nitpicks, otherwise approved

jaredmoo · 2018-09-13T23:36:48Z

...fication/sql/resource-manager/Microsoft.Sql/preview/2015-05-01-preview/managedInstances.json

+          "readOnly": true
+        },
+        "dnsZone": {
+          "description": "The Dns Zone taht the managed instance is in.",


Typo: taht -> that

jaredmoo · 2018-09-13T23:37:03Z

...l/resource-manager/Microsoft.Sql/preview/2015-05-01-preview/examples/ManagedInstanceGet.json

-          "licenseType": "Full"
+          "licenseType": "Full",
+          "collation":  "SQL_Latin1_General_CP1_CI_AS",
+		  "dnsZone": "1b4e2caff2530"


nit: please fix indentation

jaredmoo · 2018-09-14T00:43:12Z

.../resource-manager/Microsoft.Sql/preview/2015-05-01-preview/examples/ManagedInstanceList.json

-              "licenseType": "Full"
+              "licenseType": "Full",
+              "collation":  "SQL_Latin1_General_CP1_CI_AS",
+			  "dnsZone": "1b4e2caff2530"


nit: fix indentation

lmazuel · 2018-09-18T20:32:10Z

If @jaredmoo is good, I am too ;)

AutorestCI · 2018-09-18T20:32:52Z

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

jaredmoo · 2018-09-18T20:33:01Z

Thanks!

ziwa-msft added 3 commits September 11, 2018 18:34

rebasing

9c17486

Adding DnsZonePartner and Collation to Managed Instance

6b1e4c3

Merge branch 'master' of https://github.com/ziwa-msft/azure-rest-api-…

d2e5203

…specs

azuresdkci assigned lmazuel Sep 12, 2018

azuresdkci requested a review from lmazuel September 12, 2018 01:52

AutorestCI mentioned this pull request Sep 12, 2018

[AutoPR sql/resource-manager] Swagger Changes to Add DnsZonePartner and Collation into Managed Instance Azure/azure-sdk-for-python#3323

Merged

AutorestCI mentioned this pull request Sep 12, 2018

[AutoPR sql/resource-manager] Swagger Changes to Add DnsZonePartner and Collation into Managed Instance Azure/azure-sdk-for-ruby#1634

Merged

AutorestCI mentioned this pull request Sep 12, 2018

[AutoPR sql/resource-manager] Swagger Changes to Add DnsZonePartner and Collation into Managed Instance Azure/azure-sdk-for-go#2672

Closed

AutorestCI mentioned this pull request Sep 12, 2018

[AutoPR sql/resource-manager] Swagger Changes to Add DnsZonePartner and Collation into Managed Instance Azure/azure-sdk-for-node#3576

Closed

jaredmoo suggested changes Sep 12, 2018

View reviewed changes

ziwa-msft added 5 commits September 12, 2018 16:32

Regenerating Swagger based on latest REST API

d06fc48

Adding Dns Zone to all examples

999c870

Manually changing reference to types.json for SKU and ResourceIdentity

746a9c6

Manually removing specific definations for SKU and ResourceIdentity

c4ce7b1

Adding DnsZone into FQDN for MI Examples

9ed45e1

jaredmoo approved these changes Sep 14, 2018

View reviewed changes

Fix indentations and misspel

4e408cf

AutorestCI mentioned this pull request Sep 18, 2018

[AutoPR sql/resource-manager] Swagger Changes to Add DnsZonePartner and Collation into Managed Instance Azure/azure-sdk-for-go#2721

Merged

jaredmoo approved these changes Sep 18, 2018

View reviewed changes

storak approved these changes Sep 18, 2018

View reviewed changes

lmazuel merged commit 8671154 into Azure:master Sep 18, 2018

ziwa-msft mentioned this pull request Sep 28, 2018

Add DnsZonePartner Parameter to MI Creation Azure/azure-sdk-for-net#4801

Merged

Swagger Changes to Add DnsZonePartner and Collation into Managed Instance #3875

Swagger Changes to Add DnsZonePartner and Collation into Managed Instance #3875

Uh oh!

Conversation

ziwa-msft commented Sep 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR information

Quality of Swagger

Uh oh!

azuresdkci commented Sep 12, 2018

Uh oh!

AutorestCI commented Sep 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Sep 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented Sep 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

AutorestCI commented Sep 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

AutorestCI commented Sep 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ziwa-msft Sep 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jaredmoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lmazuel commented Sep 18, 2018

Uh oh!

AutorestCI commented Sep 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

jaredmoo commented Sep 18, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ziwa-msft commented Sep 12, 2018 •

edited

Loading

AutorestCI commented Sep 12, 2018 •

edited

Loading

AutorestCI commented Sep 12, 2018 •

edited

Loading

AutorestCI commented Sep 12, 2018 •

edited

Loading

AutorestCI commented Sep 12, 2018 •

edited

Loading

AutorestCI commented Sep 12, 2018 •

edited

Loading

ziwa-msft Sep 12, 2018 •

edited

Loading

AutorestCI commented Sep 18, 2018 •

edited

Loading