Skip to content

Conversation

@quintinb
Copy link
Contributor

@quintinb quintinb commented Sep 7, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-versionin the path should match theapi-version` in the spec).

Quality of Swagger

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Sep 7, 2018

Automation for azure-sdk-for-python

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • network/resource-manager
  • mediaservices/resource-manager
  • automation/resource-manager
  • containerservices/resource-manager
  • guestconfiguration/resource-manager
  • machinelearningservices/resource-manager
  • datalake-analytics/data-plane
  • applicationinsights/data-plane
  • logic/resource-manager
  • azsadmin/resource-manager/backup
  • azsadmin/resource-manager/backup/Microsoft.Backup.Admin
  • datafactory/resource-manager
  • monitor/resource-manager
  • monitor/data-plane
  • dns/resource-manager
  • cognitiveservices/data-plane/LUIS/Authoring
  • adhybridhealthservice/resource-manager
  • eventgrid/resource-manager
  • authorization/resource-manager
  • netapp/resource-manager
  • cognitiveservices/data-plane/CustomWebSearch
  • alertsmanagement/resource-manager
  • compute/resource-manager
  • mariadb/resource-manager
  • cognitiveservices/data-plane/CustomImageSearch

@AutorestCI
Copy link

AutorestCI commented Sep 7, 2018

Automation for azure-sdk-for-ruby

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • cognitiveservices/data-plane/CustomImageSearch
  • azsadmin/resource-manager/backup
  • machinelearningservices/resource-manager
  • adhybridhealthservice/resource-manager
  • cognitiveservices/data-plane/LUIS/Authoring
  • monitor/resource-manager
  • netapp/resource-manager
  • dns/resource-manager
  • datalake-analytics/data-plane
  • applicationinsights/data-plane
  • cognitiveservices/data-plane/CustomWebSearch
  • network/resource-manager
  • authorization/resource-manager
  • datafactory/resource-manager
  • automation/resource-manager
  • azsadmin/resource-manager/backup/Microsoft.Backup.Admin
  • containerservices/resource-manager
  • mediaservices/resource-manager
  • alertsmanagement/resource-manager
  • compute/resource-manager
  • eventgrid/resource-manager
  • guestconfiguration/resource-manager
  • mariadb/resource-manager
  • monitor/data-plane
  • logic/resource-manager

@AutorestCI
Copy link

AutorestCI commented Sep 7, 2018

Automation for azure-sdk-for-node

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • containerservices/resource-manager
  • cognitiveservices/data-plane/CustomWebSearch
  • mediaservices/resource-manager
  • dns/resource-manager
  • authorization/resource-manager
  • datafactory/resource-manager
  • guestconfiguration/resource-manager
  • monitor/data-plane
  • mariadb/resource-manager
  • azsadmin/resource-manager/backup
  • alertsmanagement/resource-manager
  • datalake-analytics/data-plane
  • applicationinsights/data-plane
  • netapp/resource-manager
  • cognitiveservices/data-plane/LUIS/Authoring
  • automation/resource-manager
  • azsadmin/resource-manager/backup/Microsoft.Backup.Admin
  • monitor/resource-manager
  • compute/resource-manager
  • machinelearningservices/resource-manager
  • cognitiveservices/data-plane/CustomImageSearch
  • eventgrid/resource-manager
  • adhybridhealthservice/resource-manager
  • network/resource-manager
  • logic/resource-manager

@AutorestCI
Copy link

AutorestCI commented Sep 7, 2018

Automation for azure-sdk-for-go

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • monitor/data-plane
  • datafactory/resource-manager
  • eventgrid/resource-manager
  • compute/resource-manager
  • applicationinsights/data-plane
  • netapp/resource-manager
  • alertsmanagement/resource-manager
  • cognitiveservices/data-plane/LUIS/Authoring
  • automation/resource-manager
  • cognitiveservices/data-plane/CustomImageSearch
  • logic/resource-manager
  • dns/resource-manager
  • azsadmin/resource-manager/backup/Microsoft.Backup.Admin
  • adhybridhealthservice/resource-manager
  • guestconfiguration/resource-manager
  • mariadb/resource-manager
  • monitor/resource-manager
  • machinelearningservices/resource-manager
  • mediaservices/resource-manager
  • network/resource-manager
  • azsadmin/resource-manager/backup
  • datalake-analytics/data-plane
  • authorization/resource-manager
  • containerservices/resource-manager
  • cognitiveservices/data-plane/CustomWebSearch

@AutorestCI
Copy link

AutorestCI commented Sep 7, 2018

Automation for azure-sdk-for-java

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • datalake-analytics/data-plane
  • compute/resource-manager
  • guestconfiguration/resource-manager
  • netapp/resource-manager
  • network/resource-manager
  • authorization/resource-manager
  • datafactory/resource-manager
  • dns/resource-manager
  • logic/resource-manager
  • cognitiveservices/data-plane/CustomWebSearch
  • eventgrid/resource-manager
  • containerservices/resource-manager
  • applicationinsights/data-plane
  • machinelearningservices/resource-manager
  • alertsmanagement/resource-manager
  • automation/resource-manager
  • azsadmin/resource-manager/backup/Microsoft.Backup.Admin
  • azsadmin/resource-manager/backup
  • cognitiveservices/data-plane/CustomImageSearch
  • mariadb/resource-manager
  • mediaservices/resource-manager
  • monitor/data-plane
  • cognitiveservices/data-plane/LUIS/Authoring
  • adhybridhealthservice/resource-manager
  • monitor/resource-manager

viveklingaiah and others added 3 commits September 7, 2018 11:30
* [ADF] Bringing back additionalProperties in Activity removed by mistake

* add github token api and exposure control api

* Removing Exposure Control API for now.

* Removing the example for ExposureControl API

* Fixed the example and made the response readonly

* Removing readonly from access token
daozha and others added 21 commits September 18, 2018 11:09
* Microsoft.Backup.Admin copy API version 2018-09-01 from 2016-05-01

* Update Microsoft.Backup.Admin API version 2018-09-01

* resolve comments
* Add degreeOfParallelismPercent to JobInformationBasic

* Add degreeOfParallelismPercent to JobInformationBasic

* add degreeOfParallelism to preview API
:wq
:wq
�
… version 2018-07-01 (#3927)

* Clone existing ApiVersion 2018-07-01

* Change folder structures and remove versions from readme*

* Review comments incorporation.

* Add go

* one tag only

* fix version
nodejs:
source-code-folder-path: lib/job
``` No newline at end of file
generate-license-txt: true
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert the changes in this file. I just made these changes and this PR is attempting to undo them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I messed up a merge. Please stand by...

- >-
if [[ $MODE == 'java' ]]; then
travis_wait 30 scripts/swagger-to-sdk.sh Azure/azure-libraries-for-java -v
travis_wait 30 scripts/swagger-to-sdk.sh Azure/azure-sdk-for-java -v
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that azure-libraries-for-java is correct, so this is probably wrong.

@anuchandy
Copy link
Member

Closing this PR in-favor of #3980

@anuchandy anuchandy closed this Sep 26, 2018
@AutorestCI
Copy link

AutorestCI commented Sep 26, 2018

Automation for azure-sdk-for-js

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • azsadmin/resource-manager/backup/Microsoft.Backup.Admin
  • machinelearningservices/resource-manager
  • cognitiveservices/data-plane/CustomWebSearch
  • dns/resource-manager
  • logic/resource-manager
  • eventgrid/resource-manager
  • containerservices/resource-manager
  • authorization/resource-manager
  • cognitiveservices/data-plane/LUIS/Authoring
  • compute/resource-manager
  • azsadmin/resource-manager/backup
  • guestconfiguration/resource-manager
  • network/resource-manager
  • mariadb/resource-manager
  • monitor/data-plane
  • netapp/resource-manager
  • automation/resource-manager
  • datalake-analytics/data-plane
  • mediaservices/resource-manager
  • alertsmanagement/resource-manager
  • applicationinsights/data-plane
  • adhybridhealthservice/resource-manager
  • monitor/resource-manager
  • cognitiveservices/data-plane/CustomImageSearch
  • datafactory/resource-manager

@vladbarosan vladbarosan deleted the dev-mediaservices-Microsoft.Media-2018-07-01 branch March 28, 2019 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Development

Successfully merging this pull request may close these issues.