add security fields to directline channel site for botservice#3817
Merged
annatisch merged 3 commits intoAzure:masterfrom Sep 6, 2018
swagatmishra2007:master
Merged
add security fields to directline channel site for botservice#3817annatisch merged 3 commits intoAzure:masterfrom swagatmishra2007:master
annatisch merged 3 commits intoAzure:masterfrom
swagatmishra2007:master
Conversation
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Contributor
|
Can one of the admins verify this patch? |
Automation for azure-sdk-for-nodeNothing to generate for azure-sdk-for-node |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
annatisch
requested changes
Sep 6, 2018
| }, | ||
| "trustedOrigins": { | ||
| "type": "array", | ||
| "description": "List of Trusted Origin url's for this site.Empty if isSecureSiteEnabled is False.", |
Member
There was a problem hiding this comment.
- "URLs"
- "...site. This will be empty if..."
annatisch
reviewed
Sep 6, 2018
| }, | ||
| "trustedOrigins": { | ||
| "type": "array", | ||
| "description": "List of Trusted Origin url's for this site.This field is applicable only if isSecureSiteEnabled is True.", |
Member
There was a problem hiding this comment.
@swagatmishra2007 - You didn't actually fix it :)
- Please capitalize "URLs"
- Please add a space character (" ") after the period (".").
annatisch
approved these changes
Sep 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger