Add swagger spec for new resource type in Microsoft.PolicyInsights #3815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a spec of a new preview resource type for the Microsoft.PolicyInsights- PolicyTrackedResources. The new resource type is only avaliable in the 2018-07-01-preview API version. The API itself is already deployed and passed an initial review by the ARM team.
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Contributor
|
Can one of the admins verify this patch? |
Automation for azure-sdk-for-nodeNothing to generate for azure-sdk-for-node |
dsgouda
suggested changes
Sep 6, 2018
Contributor
dsgouda
left a comment
dsgouda
left a comment
There was a problem hiding this comment.
Please create a new tag in the config file (readme.md) that references this version
This enables the linter in CI to run against these specs
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
Automation for azure-sdk-for-javaThe initial PR has been merged into your service PR: |
dsgouda
suggested changes
Sep 7, 2018
Contributor
dsgouda
left a comment
dsgouda
left a comment
There was a problem hiding this comment.
Looks OK apart from a few comments
...urce-manager/Microsoft.PolicyInsights/preview/2018-07-01-preview/policyTrackedResources.json
Show resolved
Hide resolved
...urce-manager/Microsoft.PolicyInsights/preview/2018-07-01-preview/policyTrackedResources.json
Show resolved
Hide resolved
...urce-manager/Microsoft.PolicyInsights/preview/2018-07-01-preview/policyTrackedResources.json
Show resolved
Hide resolved
...urce-manager/Microsoft.PolicyInsights/preview/2018-07-01-preview/policyTrackedResources.json
Outdated
Show resolved
Hide resolved
...urce-manager/Microsoft.PolicyInsights/preview/2018-07-01-preview/policyTrackedResources.json
Show resolved
Hide resolved
- Moved subscriptionId and apiVersion parameters to the end of the sections. - Removed the 'required' section from the definitions (irrelevant since the API doesn't support PUT operations). - Marked readonly properties.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a spec of a new preview resource type for the Microsoft.PolicyInsights- PolicyTrackedResources.
The new resource type is only avaliable in the 2018-07-01-preview API version. It only supports POSTing query (like other resource types in Microsoft.PolicyInsights).
The API itself is already deployed and passed an initial review by the ARM team.
If required, I can provide a short document that describes the API in more detail.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger