Skip to content

Conversation

@michimune
Copy link
Contributor

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Sep 5, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3312

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Sep 5, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Sep 5, 2018

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@AutorestCI
Copy link

AutorestCI commented Sep 5, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3621

@AutorestCI
Copy link

AutorestCI commented Sep 6, 2018

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2218

@sarangan12
Copy link
Contributor

@michimune Please add the required examples for the new additions in the swagger

@sarangan12
Copy link
Contributor

@michimune Any updates on adding the examples??

@michimune
Copy link
Contributor Author

@sarangan12 Pushed the examples.

@naveedaz
Copy link
Contributor

@sarangan12 Do you know why CIs for "SDK Generation - Go" and "SDK Generation - Node" are stuck?

@michimune
Copy link
Contributor Author

I found more things to fix in the result of the Model Validator. I am working on it.

@michimune
Copy link
Contributor Author

Sorry, we found more issues. I am working on fix now.

@michimune
Copy link
Contributor Author

@sarangan12 @naveedaz I believe we are in a good state, finally. Can you please check?

@naveedaz
Copy link
Contributor

@michimune Looks good.

@sarangan12 sarangan12 merged commit 6294790 into Azure:master Sep 17, 2018
@jhendrixMSFT
Copy link
Member

@AutorestCI regenerate azure-sdk-for-go

@AutorestCI
Copy link

Encountered a Subprocess error

Command: ['/usr/local/bin/autorest', '/tmp/tmpx4ig45ky/rest/specification/web/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmpx4ig45ky/src/github.com/Azure/azure-sdk-for-go', '--multiapi', '[email protected]/autorest.go@~2.1.113', '--use-onever', '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.11.4]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4283)
  Error: Unable to resolve package '@microsoft.azure/autorest.go@~2.1.113'.

@michimune
Copy link
Contributor Author

The error message from the AutorestCI: Error: Unable to resolve package '@microsoft.azure/autorest.go@~2.1.113'.

Does this mean the CI has an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants