Skip to content

Microsoft.ResourceGraph - Promote additionalProperties to a dictionary #3796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lmazuel merged 1 commit into from
Sep 4, 2018
Merged

Microsoft.ResourceGraph - Promote additionalProperties to a dictionary #3796

lmazuel merged 1 commit into from
Sep 4, 2018

Conversation

@ilidemi
Copy link
Contributor

@ilidemi ilidemi commented Aug 31, 2018 •
edited
Loading

Building on top of #3716.

Current spec generates AdditionalProperties as object, it would be more convenient to have a Dictionary<string, object> instead.

This is not a breaking change as the RP backend is not live yet.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@azuresdkci
Copy link
Contributor

azuresdkci commented Aug 31, 2018

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Aug 31, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Aug 31, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3208

@azuresdkci azuresdkci assigned lmazuel and unassigned jhendrixMSFT Sep 1, 2018
@azuresdkci azuresdkci requested a review from lmazuel September 1, 2018 01:33
@AutorestCI
Copy link

AutorestCI commented Sep 1, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Sep 1, 2018 •
edited
Loading

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@AutorestCI
Copy link

AutorestCI commented Sep 1, 2018 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Sep 1, 2018 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@lmazuel lmazuel merged commit 7eb1987 into Azure:master Sep 4, 2018
This was referenced Sep 4, 2018
Merged
Merged
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
@subbartt
Exposing resource status information as readonly property... (#3796)
2737764 
* Making OSType puttable

* Adding readonly resource status information
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmazuel lmazuel lmazuel approved these changes

@jhendrixMSFT jhendrixMSFT Awaiting requested review from jhendrixMSFT

Assignees

@lmazuel lmazuel

Labels

Reassign

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ilidemi @azuresdkci @AutorestCI @lmazuel @jhendrixMSFT