Skip to content

Add 201 response to AppServicePlans_CreateOrUpdate. #3774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pietro wants to merge 1 commit into from
Closed

Add 201 response to AppServicePlans_CreateOrUpdate. #3774

pietro wants to merge 1 commit into from

Conversation

@pietro
Copy link
Contributor

@pietro pietro commented Aug 30, 2018

Fixes #3648.

@msftclas
Copy link

msftclas commented Aug 30, 2018 •
edited
Loading

CLA assistant check
All CLA requirements met.

@azuresdkci azuresdkci requested a review from anuchandy August 30, 2018 21:39
@azuresdkci
Copy link
Contributor

azuresdkci commented Aug 30, 2018

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Aug 30, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Aug 30, 2018 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#3312

@AutorestCI AutorestCI mentioned this pull request Aug 30, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Aug 30, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-ruby#1611

This was referenced Aug 30, 2018
Closed
Closed
@AutorestCI AutorestCI mentioned this pull request Aug 30, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Aug 30, 2018 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#2684

@AutorestCI
Copy link

AutorestCI commented Aug 30, 2018 •
edited
Loading

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#3590

@AutorestCI
Copy link

AutorestCI commented Aug 31, 2018 •
edited
Loading

Automation for azure-sdk-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-java#2218

anuchandy
anuchandy requested changes Sep 3, 2018
View reviewed changes
Copy link
Member

@anuchandy anuchandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@piebie Please fix the examples. For instance the response body in the example contains properties those are not present in the model.

Also there is no example for 201 response code.

@anuchandy
Copy link
Member

anuchandy commented Sep 12, 2018

Closing this due to inactivity. Feel free to open a new PR when you are ready.

@anuchandy anuchandy closed this Sep 12, 2018
This was referenced Sep 12, 2018
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anuchandy anuchandy anuchandy requested changes

Assignees

@anuchandy anuchandy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pietro @msftclas @azuresdkci @AutorestCI @anuchandy