Skip to content

Added the replica count API change to Shared Image Gallery swagger file. #3757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Joel Hendrix (jhendrixMSFT) merged 2 commits into from
Aug 31, 2018
Merged

Added the replica count API change to Shared Image Gallery swagger file. #3757

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8741aed
Added the replica count change.
vanbasten2323 Aug 29, 2018
0ac9f54
Updated the examples.
vanbasten2323 Aug 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 21 additions & 14 deletions specification/compute/resource-manager/Microsoft.Compute/stable/2018-06-01/gallery.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1053,12 +1053,12 @@
},
"GalleryArtifactPublishingProfileBase": {
"properties": {
"regions": {
"targetRegions": {
"type": "array",
"items": {
"type": "string"
"$ref": "#/definitions/TargetRegion"
},
"description": "The regions where the artifact is going to be published."
"description": "The target regions where the artifact is going to be published."
},
"source": {
"$ref": "#/definitions/GalleryArtifactSource"
Expand All @@ -1069,6 +1069,20 @@
],
"description": "Describes the basic gallery artifact publishing profile."
},
"TargetRegion": {
"properties": {
"name": {
"type": "string",
"description": "The name of the region."
},
"regionalReplicaCount": {

@huangpf huangpf Aug 29, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the name of the region is called name, why the replica count still has the region as the property's prefix? Why not just replicaCount?

@vanbasten2323 vanbasten2323 Aug 29, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Initially, we call it "replicaCount", the same as you suggested. Then we got some feedback from Kay Singh that it might be clearer to use "regionalReplicaCount". So we use this.

@huangpf huangpf Aug 29, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

"type": "integer",
"format": "int32",
"description": "This is the number of source blob copies in this specific region."

@huangpf huangpf Aug 29, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

source blob in the source region, or in the target region? Or target blob? Please consider revising the statement to make it clearer.

@vanbasten2323 vanbasten2323 Aug 29, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it is the copies of the source blob in the target regions. Will this be better "This is the number of copies of the source blobs in this target region."?

@huangpf huangpf Aug 29, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@yugangw-msft Yugang Wang (yugangw-msft) Sep 5, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vanbasten2323 what exactly is the "number of copies of the source blobs mean"?

@yugangw-msft Yugang Wang (yugangw-msft) Sep 5, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kay Singh (@singhkays), the original mail communicates the new name would be scaleTier, so i am bit confused now. Can you guys offer some explanation, so i can communicate better to CLI users.

@yugangw-msft Yugang Wang (yugangw-msft) Sep 5, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, what is the service end default value for this?

@singhkays Kay Singh (singhkays) Sep 5, 2018

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarified in offline call

}
},
"description": "Describes the target region information."
},
"GalleryArtifactSource": {
"properties": {
"managedImage": {
Expand All @@ -1094,17 +1108,10 @@
},
"GalleryImageVersionPublishingProfile": {
"properties": {
"scaleTier": {
"type": "string",
"description": "The scale tier of the gallery image version. Valid values are 'S30' and 'S100'",
"enum": [
"S30",
"S100"
],
"x-ms-enum": {
"name": "ScaleTier",
"modelAsString": true
}
"replicaCount": {
"type": "integer",
"format": "int32",
"description": "This is the number of source blob copies in a region."
},
"excludeFromLatest": {
"type": "boolean",
Expand Down