Skip to content

Conversation

@welovej
Copy link
Member

@welovej welovej commented Sep 16, 2025

SDK configuration pull request

Purpose of this PR

  • Make changes to the SDK configuration only when there are no modifications to the API specification, eliminating the need for an ARM or Stewardship Board API review.

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

Getting help

  • First, carefully read through this PR description, from top to bottom. Fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure and https://aka.ms/ci-fix.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

@github-actions
Copy link

github-actions bot commented Sep 16, 2025

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Comment generated by summarize-checks workflow run.

@github-actions github-actions bot added resource-manager TypeSpec Authored with TypeSpec labels Sep 16, 2025
@ArcturusZhang ArcturusZhang marked this pull request as ready for review September 16, 2025 08:15
@github-actions github-actions bot added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 16, 2025
@github-actions
Copy link

github-actions bot commented Sep 16, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Java com.azure.resourcemanager:azure-resourcemanager-selfhelp
JavaScript @azure/arm-selfhelp

@ArcturusZhang ArcturusZhang added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 16, 2025
@ArcturusZhang
Copy link
Member

nothing changed in the spec, just csharp configurations.

@ArcturusZhang ArcturusZhang added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Sep 16, 2025
@ArcturusZhang ArcturusZhang merged commit 9e8f84c into Azure:main Sep 17, 2025
114 of 115 checks passed
markcowl pushed a commit to markcowl/azure-rest-api-specs that referenced this pull request Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager TypeSpec Authored with TypeSpec

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants