-
Notifications
You must be signed in to change notification settings - Fork 5.6k
AMR Migration feature APIs 2025-08-01-preview #37184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AMR Migration feature APIs 2025-08-01-preview #37184
Conversation
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.Comment generated by summarize-checks workflow run. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
f8bc975 to
673f646
Compare
I'm feeling a little confused about why/when we need this property. Is it supposed to be the 'id' of the redisEnterprise cluster that the migration is to? Even though its also in the URI of the migration resource? I don't see a problem with having it, I just want to understand how its going to be used. Refers to: specification/redisenterprise/resource-manager/Microsoft.Cache/preview/2025-08-01-preview/redisenterprise.json:3112 in d7124cf. [](commit_id = d7124cf, deletion_comment = False) |
This should just be "Microsoft.Cache/redis", right? There is no RedisResource subtype. Refers to: specification/redisenterprise/resource-manager/Microsoft.Cache/preview/2025-08-01-preview/redisenterprise.json:3169 in 673f646. [](commit_id = 673f646, deletion_comment = False) |
I think it makes sense to document the 'default' for switchDns, maybe even specify it in swagger Refers to: specification/redisenterprise/resource-manager/Microsoft.Cache/preview/2025-08-01-preview/redisenterprise.json:3177 in d7124cf. [](commit_id = d7124cf, deletion_comment = False) |
I think it makes sense to document the 'default' for skipDataMigration, maybe even specify it in swagger Refers to: specification/redisenterprise/resource-manager/Microsoft.Cache/preview/2025-08-01-preview/redisenterprise.json:3182 in d7124cf. [](commit_id = d7124cf, deletion_comment = False) |
Oh never mind - there is no default, because its required and you must set it to true. In reply to: 3271694069 Refers to: specification/redisenterprise/resource-manager/Microsoft.Cache/preview/2025-08-01-preview/redisenterprise.json:3177 in d7124cf. [](commit_id = d7124cf, deletion_comment = False) |
Oh never mind, there is no default because its required - you must opt it to 'true'. In reply to: 3271694732 Refers to: specification/redisenterprise/resource-manager/Microsoft.Cache/preview/2025-08-01-preview/redisenterprise.json:3182 in d7124cf. [](commit_id = d7124cf, deletion_comment = False) |
We can remove this property if it is necessary |
|
The service is under folder structure migration. The PR should proceed with new folder structure. Please contact [email protected] for any inquiries. When you reach out, ensure to bring the pull request you want to make progress. |
b69304f to
6344bd0
Compare
fb9edf5 to
3d2c76e
Compare
7b16299 to
29017a3
Compare
3f66e98 to
2d10d2d
Compare
2d10d2d to
401e80f
Compare
385bbaa to
24b613a
Compare
24b613a to
9af524e
Compare
ramoka178
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on previous sign off
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PRandDue diligence checklist.write accessper aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.