Conversation
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Member
Author
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
Automation for azure-sdk-for-nodeThe initial PR has been merged into your service PR: |
Contributor
|
Can one of the admins verify this patch? |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
annatisch
approved these changes
Aug 22, 2018
Member
annatisch
left a comment
annatisch
left a comment
There was a problem hiding this comment.
LGTM - though why remove the detail from the elevation level description? This no longer applies?
Member
Author
|
@annatisch - Now that we use the newer "docs go on the enum members" syntax, the docs which I deleted are actually duplicate. We had already removed most occurrences of the duplicates but missed this one. |
mccleanp
pushed a commit
that referenced
this pull request
Mar 23, 2022
…3701) * initial implementation of the Microsoft.Diagnotics Resource Provider * fix prettier errors * fix operation id & adding examples * adding examples for operations * removing solution rt and extra parameters * addin operations examples * fix linting errors and spellings * fixing examples * fixing required fields missing error * fix final error * fixing linting bugs * adding format to integer fields * lowercase errors fixed * lowercase errors fixed * adding default error * adds example InsightDiagnostics invocation and additional cleanup for lint happiness * adds missing scope parameter and example return for a 200 OK response code. * adding scope param to azurekb * adding fixes for other errors * fixing prettier issues * linting warnings enum * linting warnings enum * review comments * try last fix * review comments * adding min and max values to int field * reverting to result if Co-authored-by: Will Madison <wimadiso@microsoft.com> Co-authored-by: Aravind Bharatha <arbhara@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger