added restore deleted apps and get list of deleted apps#3696
added restore deleted apps and get list of deleted apps#3696connorlee77 wants to merge 4 commits intoAzure:masterfrom
Conversation
Automation for azure-sdk-for-pythonA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-rubyA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-goA PR has been created for you: |
|
Can one of the admins verify this patch? |
Automation for azure-sdk-for-nodeA PR has been created for you: |
Automation for azure-sdk-for-javaA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
| } | ||
| } | ||
| }, | ||
| "/{tenantID}/deletedApplications/{objectId}/restore": { |
There was a problem hiding this comment.
Looks like both of these operations are missing "parameters" definitions and causing semantic failure as seen here: https://travis-ci.org/Azure/azure-rest-api-specs/jobs/418930889#L586
|
Could @amarzavery @lmazuel @yugangw-msft test it out/fix any errors? |
|
I'm going to be OOF all next week, so this PR should be reassigned. |
| "required": true, | ||
| "type": "string", | ||
| "description": "Application object ID." | ||
| }, |
There was a problem hiding this comment.
Missing the api version to get apiversion=1.6
{
"$ref": "#/parameters/ApiVersionParameter"
},
| "operationId": "DeletedApplications_Get", | ||
| "description": "Gets a list of deleted applications in the directory.", | ||
| "parameters": [ | ||
| { |
There was a problem hiding this comment.
Missing the api version to get apiversion=1.6
{
"$ref": "#/parameters/ApiVersionParameter"
},
| "tags": [ | ||
| "Application" | ||
| ], | ||
| "operationId": "Applications_HardDelete", |
There was a problem hiding this comment.
If I understand correctly the purpose of this operation, the idea is to "purge" deletedApplications and remove for real the application without waiting 30 days. This means the app has to have been deleted before.
If that so, then operationId should be DeletedApplications_Delete
|
Left the company. |
Automation for azure-sdk-for-jsNothing to generate for azure-sdk-for-js |
5 participants
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger