Skip to content

Conversation

@yangyuan
Copy link
Member

@yangyuan yangyuan commented Aug 20, 2018

Metadata should be a dictionary. The swagger was written in a wrong way.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Aug 20, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#1963

@AutorestCI
Copy link

AutorestCI commented Aug 20, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3387

@AutorestCI
Copy link

AutorestCI commented Aug 20, 2018

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2315

@AutorestCI
Copy link

AutorestCI commented Aug 20, 2018

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1590

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Aug 20, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2501

Copy link
Member

@jhendrixMSFT jhendrixMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update the examples to match this swagger change? Model validation is failing, see the log.

@yangyuan
Copy link
Member Author

yangyuan commented Aug 21, 2018

hi @jhendrixMSFT,
It's so weird it can pass the validation locally by oav validate-example, how can I repeat the error locally?

@jhendrixMSFT
Copy link
Member

I would expect oav validate-example to work. @sergey-shandar is there something else we should be running?

@yangyuan
Copy link
Member Author

@jhendrixMSFT
Hmm.
Anyway I am trying to mitigate the issue by indicate the type as "string" instead of "object".

A little bit background, there is no breaking change in here, all previous examples should work.
I'm just trying to fix the mistakes in the swagger file. A few types should be dictionary but described with fixed fields.

@jhendrixMSFT
Copy link
Member

Unfortunately this change is breaking (thanks for reminding me, I will add the tag). As an example see the change in the Go SDK here. I understand it's the right thing to do as the swagger was wrong but we still have to track it as breaking.

@yangyuan
Copy link
Member Author

@jhendrixMSFT
Hmm, seems all validations pass now.

@jhendrixMSFT jhendrixMSFT merged commit 44cfea2 into Azure:master Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants