-
Notifications
You must be signed in to change notification settings - Fork 5.6k
[Cognitive Services] Fix metadata types for Content Moderator. #3681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-nodeThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-javaThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-rubyThe initial PR has been merged into your service PR: |
|
Can one of the admins verify this patch? |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
jhendrixMSFT
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please update the examples to match this swagger change? Model validation is failing, see the log.
|
hi @jhendrixMSFT, |
|
I would expect |
|
@jhendrixMSFT A little bit background, there is no breaking change in here, all previous examples should work. |
|
Unfortunately this change is breaking (thanks for reminding me, I will add the tag). As an example see the change in the Go SDK here. I understand it's the right thing to do as the swagger was wrong but we still have to track it as breaking. |
|
@jhendrixMSFT |
Metadata should be a dictionary. The swagger was written in a wrong way.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger