Skip to content

[Azure Container Apps] Fix sessions data-plane api spec #36644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Juliehzl merged 14 commits into from
Aug 14, 2025
Merged

[Azure Container Apps] Fix sessions data-plane api spec #36644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
928cca5
Remove unnecessary usings
yitaopan Aug 13, 2025
2c5849c
test regex
yitaopan Aug 13, 2025
3f99162
fix
yitaopan Aug 13, 2025
08334e7
test
yitaopan Aug 13, 2025
449c483
fix
yitaopan Aug 13, 2025
b356415
fix
yitaopan Aug 13, 2025
7b77a14
fix
yitaopan Aug 13, 2025
ebd0fba
test
yitaopan Aug 13, 2025
2d879c6
test
yitaopan Aug 13, 2025
614c2fd
test
yitaopan Aug 13, 2025
6ed6837
fix
yitaopan Aug 13, 2025
613635d
fix
yitaopan Aug 13, 2025
d5c4817
Merge branch 'main' into yitaopan/fix-session-dp-swagger
yitaopan Aug 13, 2025
068cd5c
Merge branch 'main' into yitaopan/fix-session-dp-swagger
yitaopan Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion specification/app/Microsoft.App.DynamicSessions/main.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import "@azure-tools/typespec-azure-core";
import "./routes.tsp";

using TypeSpec.Http;
using TypeSpec.Rest;
using TypeSpec.Versioning;
using Azure.Core;

Expand Down
1 change: 0 additions & 1 deletion specification/app/Microsoft.App.DynamicSessions/models/code-execution-file.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import "./common.tsp";
using TypeSpec.Http;
using TypeSpec.Rest;

namespace Microsoft.App.DynamicSessions;
Expand Down
3 changes: 1 addition & 2 deletions specification/app/Microsoft.App.DynamicSessions/models/code-execution.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import "./common.tsp";
using Azure.Core;
using TypeSpec.Http;
using TypeSpec.Rest;

namespace Microsoft.App.DynamicSessions;
Expand All @@ -17,7 +16,7 @@ model SessionCodeExecutionRequest {
code: string;

@doc("Code execution timeout in seconds.")
timeoutInSeconds: int64;
timeoutInSeconds: int32;
}

@doc("The result of the code execution.")
Expand Down
5 changes: 1 addition & 4 deletions specification/app/Microsoft.App.DynamicSessions/models/common.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,8 @@
import "@azure-tools/typespec-azure-resource-manager";

using Azure.Core;
using TypeSpec.Http;
using TypeSpec.Rest;

namespace Microsoft.App.DynamicSessions;
using OpenAPI;

@doc("The optional execution id header.")
model ExecutionOperationIdHeader {
Expand All @@ -20,7 +17,7 @@ model SessionIdentifier {
@query
@minLength(1)
@maxLength(256)
@pattern("^[A-Za-z0-9-_]{1,256}$")
@pattern("^[a-zA-Z0-9_|}{\\[\\]\\:\"\";'<>?\\/.,@#$%\\^&*()_\\-+=!~`]{4,128}$")
identifier: string;
}

Expand Down
2 changes: 0 additions & 2 deletions specification/app/Microsoft.App.DynamicSessions/models/session.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
import "./common.tsp";
using Azure.Core;
using TypeSpec.Http;
using TypeSpec.Rest;
using TypeSpec.Versioning;

namespace Microsoft.App.DynamicSessions;
Expand Down
3 changes: 0 additions & 3 deletions specification/app/Microsoft.App.DynamicSessions/models/sessionpool-metadata.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
import "./common.tsp";
using Azure.Core;
using TypeSpec.Http;
using TypeSpec.Rest;
using TypeSpec.Versioning;

namespace Microsoft.App.DynamicSessions;
Expand Down
4 changes: 2 additions & 2 deletions .../data-plane/Microsoft.App.DynamicSessions/preview/2024-10-02-preview/DynamicSessions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,7 +634,7 @@
},
"timeoutInSeconds": {
"type": "integer",
"format": "int64",
"format": "int32",
"description": "Code execution timeout in seconds."
}
},
Expand Down Expand Up @@ -800,7 +800,7 @@
"type": "string",
"minLength": 1,
"maxLength": 256,
"pattern": "^[A-Za-z0-9-_]{1,256}$",
"pattern": "^[a-zA-Z0-9_|}{\\[\\]\\:\"\";'<>?\\/.,@#$%\\^&*()_\\-+=!~`]{4,128}$",
"x-ms-parameter-location": "method"
},
"SessionResourceFilePathQueryParameter": {
Expand Down
4 changes: 2 additions & 2 deletions .../data-plane/Microsoft.App.DynamicSessions/preview/2025-02-02-preview/DynamicSessions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -892,7 +892,7 @@
},
"timeoutInSeconds": {
"type": "integer",
"format": "int64",
"format": "int32",
"description": "Code execution timeout in seconds."
}
},
Expand Down Expand Up @@ -1120,7 +1120,7 @@
"type": "string",
"minLength": 1,
"maxLength": 256,
"pattern": "^[A-Za-z0-9-_]{1,256}$",
"pattern": "^[a-zA-Z0-9_|}{\\[\\]\\:\"\";'<>?\\/.,@#$%\\^&*()_\\-+=!~`]{4,128}$",
"x-ms-parameter-location": "method"
},
"SessionResourceFilePathQueryParameter": {
Expand Down
Loading