Skip to content

Microsot.Network/virtualnetworkgateways Reset VPN Client Shared Key #3649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sergey-shandar merged 3 commits into from
Sep 5, 2018
Merged

Microsot.Network/virtualnetworkgateways Reset VPN Client Shared Key #3649

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be44f71
Reset VPN Client shared key
henry416 Aug 15, 2018
fb70fd5
typo
henry416 Aug 15, 2018
aafca9c
CR rename
henry416 Aug 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions ...soft.Network/stable/2018-06-01/examples/VirtualNetworkGatewayResetVpnClientSharedKey.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"parameters": {
"api-version": "2018-06-01",
"subscriptionId": "subid",
"resourceGroupName": "rg1",
"virtualNetworkGatewayName" : "vpngw"
},
"responses" : {
"202" : { },
"200" : { }
}
}
43 changes: 43 additions & 0 deletions ...n/network/resource-manager/Microsoft.Network/stable/2018-06-01/virtualNetworkGateway.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,6 +362,49 @@
"x-ms-long-running-operation": true
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualNetworkGateways/{virtualNetworkGatewayName}/resetvpnclientsharedkey": {
Copy link
Contributor

@sergey-shandar sergey-shandar Aug 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have this operations in other API versions as well? 2018-07-01?

Copy link
Member Author

@henry416 henry416 Aug 17, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is from 2018-06-01 onwards

Copy link
Contributor

@anton-evseev anton-evseev Aug 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@henry416 in this case you might need to port the changes to 2018-07-01 as well. Also 2018-08-01 (working branch for that version is Network-September-Release)

Copy link
Member Author

@henry416 henry416 Aug 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@number213 If that is the case, I will open another PR for the 2018-08-01 version instead

"post": {
"tags": [
"VirtualNetworkGateways"
],
"operationId": "VirtualNetworkGateways_Resetvpnclientsharedkey",
Copy link
Contributor

@sergey-shandar sergey-shandar Aug 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we have a better name? For example VirtualNetworkGateways_ResetVpnClientSharedKey

Copy link
Member Author

@henry416 henry416 Aug 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sergey-shandar Done as requested

"description": "Resets the VPN client shared key of the virtual network gateway in the specified resource group.",
"parameters": [
{
"name": "resourceGroupName",
"in": "path",
"required": true,
"type": "string",
"description": "The name of the resource group."
},
{
"name": "virtualNetworkGatewayName",
"in": "path",
"required": true,
"type": "string",
"description": "The name of the virtual network gateway."
},
{
"$ref": "./network.json#/parameters/ApiVersionParameter"
},
{
"$ref": "./network.json#/parameters/SubscriptionIdParameter"
}
],
"responses": {
"200": {
"description": "Request successful. The operation reset the vpn client shared key of the virtual network gateway."
},
"202": {
"description": "Accepted and the operation will complete asynchronously"
}
},
"x-ms-examples": {
"ResetVpnClientSharedKey": { "$ref": "./examples/VirtualNetworkGatewayResetVpnClientSharedKey.json" }
},
"x-ms-long-running-operation": true
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualNetworkGateways/{virtualNetworkGatewayName}/generatevpnclientpackage": {
"post": {
"tags": [
Expand Down