Skip to content

[CogSvc] Fix 2025-04-01-preview and 2025-06-01 stable API to match service behavior for account networkInjections property #36395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 19, 2025
Merged

[CogSvc] Fix 2025-04-01-preview and 2025-06-01 stable API to match service behavior for account networkInjections property #36395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8472d60
Fix API to match service behavior for account networkInjections property
CarlOchs Aug 1, 2025
48941f5
Fix 2025-04-01 preview API to match service behavior for account netw…
CarlOchs Aug 1, 2025
1bdc89b
Merge branch 'main' into carlochs/cogsvc-2025-06-01-property-bugfix
CarlOchs Aug 12, 2025
29f7d63
Merge branch 'main' into carlochs/cogsvc-2025-06-01-property-bugfix
razvanbadea-msft Aug 13, 2025
ea9ffb1
add suppression
Aug 19, 2025
82fa4c8
Merge branch 'main' into carlochs/cogsvc-2025-06-01-property-bugfix
jliusan Aug 19, 2025
a12e3f7
Merge branch 'main' into carlochs/cogsvc-2025-06-01-property-bugfix
jliusan Aug 19, 2025
c943bd2
add suppression
Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ...rce-manager/Microsoft.CognitiveServices/preview/2025-04-01-preview/cognitiveservices.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{

Check notice on line 1 in specification/cognitiveservices/resource-manager/Microsoft.CognitiveServices/preview/2025-04-01-preview/cognitiveservices.json

View workflow job for this annotation

GitHub Actions / TypeSpec Requirement 

Your service description will soon be required to convert from OpenAPI to TypeSpec. See https://aka.ms/azsdk/typespec.
"swagger": "2.0",
"info": {
"title": "CognitiveServicesManagementClient",
Expand Down Expand Up @@ -5222,7 +5222,10 @@
"$ref": "#/definitions/RaiMonitorConfig"
},
"networkInjections": {
"$ref": "#/definitions/NetworkInjections"
"type": "array",
"items": {
"$ref": "#/definitions/NetworkInjection"
}
},
"allowProjectManagement": {
"type": "boolean",
Expand Down Expand Up @@ -8810,7 +8813,7 @@
},
"additionalProperties": false
},
"NetworkInjections": {
"NetworkInjection": {
"description": "Specifies in AI Foundry where virtual network injection occurs to secure scenarios like Agents entirely within the user's private network, eliminating public internet exposure while maintaining control over network configurations and resources.",
"type": "object",
"properties": {
Expand Down
7 changes: 5 additions & 2 deletions ...ces/resource-manager/Microsoft.CognitiveServices/stable/2025-06-01/cognitiveservices.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{

Check notice on line 1 in specification/cognitiveservices/resource-manager/Microsoft.CognitiveServices/stable/2025-06-01/cognitiveservices.json

View workflow job for this annotation

GitHub Actions / TypeSpec Requirement 

Your service description will soon be required to convert from OpenAPI to TypeSpec. See https://aka.ms/azsdk/typespec.
"swagger": "2.0",
"info": {
"title": "CognitiveServicesManagementClient",
Expand Down Expand Up @@ -5219,7 +5219,10 @@
"$ref": "#/definitions/RaiMonitorConfig"
},
"networkInjections": {
"$ref": "#/definitions/NetworkInjections"
"type": "array",
"items": {
"$ref": "#/definitions/NetworkInjection"
}
},
"allowProjectManagement": {
"type": "boolean",
Expand Down Expand Up @@ -8813,7 +8816,7 @@
},
"additionalProperties": false
},
"NetworkInjections": {
"NetworkInjection": {
"description": "Specifies in AI Foundry where virtual network injection occurs to secure scenarios like Agents entirely within the user's private network, eliminating public internet exposure while maintaining control over network configurations and resources.",
"type": "object",
"properties": {
Expand Down
6 changes: 6 additions & 0 deletions specification/cognitiveservices/resource-manager/sdk-suppressions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
suppressions:
azure-sdk-for-go:
- package: sdk/resourcemanager/cognitiveservices/armcognitiveservices
breaking-changes:
- Type of `AccountProperties.NetworkInjections` has been changed from `*NetworkInjections` to `[]*NetworkInjection`
- Struct `NetworkInjections` has been removed
Loading