Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions .github/workflows/breaking-change-code.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
name: "[TEST-IGNORE] Swagger BreakingChange - Analyze Code"

on: pull_request
Expand Down Expand Up @@ -56,15 +56,3 @@
name: "${{ steps.swagger-breaking-change-analyze-code.outputs.versioningReviewLabelName }}"
# Convert "add/remove" to "true/false"
value: "${{ steps.swagger-breaking-change-analyze-code.outputs.versioningReviewLabelValue == 'true' }}"

# Upload artifact with issue number if labels are present and PR number is valid
- if: |
always() &&
(steps.swagger-breaking-change-analyze-code.outputs.breakingChangeReviewLabelName != '' ||
steps.swagger-breaking-change-analyze-code.outputs.versioningReviewLabelName != '') &&
github.event.pull_request.number > 0
name: Upload artifact with issue number
uses: ./.github/actions/add-empty-artifact
with:
name: "issue-number"
value: "${{ github.event.pull_request.number }}"
12 changes: 0 additions & 12 deletions .github/workflows/breaking-change-cross-version-code.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
name: "[TEST-IGNORE] Breaking Change(Cross-Version) - Analyze Code"

on: pull_request
Expand Down Expand Up @@ -56,15 +56,3 @@
with:
name: "${{ steps.breaking-change-cross-version-analyze-code.outputs.versioningReviewLabelName }}"
value: "${{ steps.breaking-change-cross-version-analyze-code.outputs.versioningReviewLabelValue == 'true' }}"

# Upload artifact with issue number if labels are present and PR number is valid
- if: |
always() &&
(steps.breaking-change-cross-version-analyze-code.outputs.breakingChangeReviewLabelName != '' ||
steps.breaking-change-cross-version-analyze-code.outputs.versioningReviewLabelName != '') &&
github.event.pull_request.number > 0
name: Upload artifact with issue number
uses: ./.github/actions/add-empty-artifact
with:
name: "issue-number"
value: "${{ github.event.pull_request.number }}"
9 changes: 0 additions & 9 deletions .github/workflows/summarize-impact.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
name: "[TEST-IGNORE] Summarize PR Impact"

on: pull_request
Expand Down Expand Up @@ -55,12 +55,3 @@
path: ${{ steps.summarize-impact.outputs.summary }}
# If the file doesn't exist, just don't add the artifact
if-no-files-found: ignore

- if: |
always() &&
github.event.pull_request.number > 0
name: Upload artifact with issue number
uses: ./after/.github/actions/add-empty-artifact
with:
name: "issue-number"
value: "${{ github.event.pull_request.number }}"
4 changes: 4 additions & 0 deletions .github/workflows/test/context.test.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
import { describe, expect, it } from "vitest";
import { extractInputs } from "../src/context.js";
import { PER_PAGE_MAX } from "../src/github.js";
Expand Down Expand Up @@ -295,6 +295,10 @@
commit_sha: "abc123",
per_page: PER_PAGE_MAX,
});

// For pull_request, do NOT attempt to extract the issue number from an artifact, since this could be modified
// in a fork PR.
expect(github.rest.actions.listWorkflowRunArtifacts).toHaveBeenCalledTimes(0);
},
);

Expand Down
Loading