Skip to content

Revert changes to snapshot proxy resource #36225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pahnallan merged 12 commits into from
Jul 28, 2025
Merged

Revert changes to snapshot proxy resource #36225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f87895e
Revert changes to snapshot proxy resource
pahnallan Jul 28, 2025
9f68099
Update readme.md
pahnallan Jul 28, 2025
ab8b75f
Update fileshares.tsp
pahnallan Jul 28, 2025
d88c47f
Add 200 response to snapshots PATCH
pahnallan Jul 28, 2025
a428887
Update readme.md
pahnallan Jul 28, 2025
61e64db
Update readme.md
pahnallan Jul 28, 2025
86e9d0b
Update readme.md
pahnallan Jul 28, 2025
76f0277
Update readme.md
pahnallan Jul 28, 2025
a1cc05e
Update readme.md
pahnallan Jul 28, 2025
fc56152
Update readme.md
pahnallan Jul 28, 2025
ffaffa5
Add 200 response example for file share snapshots
pahnallan Jul 28, 2025
7fc46ac
Update FileShareSnapshot_Update_MaximumSet_Gen.json
pahnallan Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions ...hares.Management/examples/2025-06-01-preview/FileShareSnapshot_Update_MaximumSet_Gen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,28 @@
}
},
"responses": {
"200": {
"body": {
"properties": {
"snapshotTime": "wgujspthevkfo",
"initiatorId": "ghublxbeifhvhwokvhppbw",
"metadata": {
"key9372": "jtc"
}
},
"id": "/subscriptions/11111111-2222-3333-4444-555555555555/resourceGroups/rg1Network/providers/Microsoft.FileShares/fileShares/testfileshare/fileShareSnapshots/testfilesharesnapshot",
"name": "testfilesharesnapshot",
"type": "Microsoft.FileShares/fileShares/fileShareSnapshots",
"systemData": {
"createdBy": "moat",
"createdByType": "User",
"createdAt": "2025-07-23T12:37:53.955Z",
"lastModifiedBy": "dxukcadzapywjcgnxsqchaa",
"lastModifiedByType": "User",
"lastModifiedAt": "2025-07-23T12:37:53.955Z"
}
}
},
"202": {
"headers": {
"location": "https://contoso.com/operationstatus"
Expand Down
13 changes: 11 additions & 2 deletions specification/fileshares/FileShares.Management/fileshares.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,14 +298,23 @@ interface FileShareSnapshots {
#suppress "@azure-tools/typespec-azure-resource-manager/arm-put-operation-response-codes" "RP doesn't support 201 Created pattern for proxy resources in public preview. To be addressed in GA."
@operationId("FileShareSnapshot_CreateOrUpdate")
@doc("Create a FileShareSnapshot.")
createOrUpdateFileShareSnapshot is ArmResourceCreateOrReplaceSync<FileShareSnapshot>;
createOrUpdateFileShareSnapshot is ArmResourceCreateOrReplaceAsync<
FileShareSnapshot,
BaseParameters<FileShareSnapshot>,
Response = ArmAcceptedLroResponse<LroHeaders = ArmAsyncOperationHeader &
ArmLroLocationHeader<FinalResult = FileShareSnapshot> &
Azure.Core.Foundations.RetryAfterHeader>
>;

@operationId("FileShareSnapshot_Update")
@doc("Update a FileShareSnapshot.")
updateFileShareSnapshot is ArmCustomPatchAsync<
FileShareSnapshot,
ResourceUpdateModel<FileShareSnapshot, FileShareSnapshotProperties>,
BaseParameters<FileShareSnapshot>
BaseParameters<FileShareSnapshot>,
Response = ArmResponse<FileShareSnapshot> | ArmAcceptedLroResponse<LroHeaders = ArmAsyncOperationHeader &
ArmLroLocationHeader<FinalResult = FileShareSnapshot> &
Azure.Core.Foundations.RetryAfterHeader>
>;

@operationId("FileShareSnapshot_Delete")
Expand Down
22 changes: 22 additions & 0 deletions ...leShares/preview/2025-06-01-preview/examples/FileShareSnapshot_Update_MaximumSet_Gen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,28 @@
}
},
"responses": {
"200": {
"body": {
"properties": {
"snapshotTime": "wgujspthevkfo",
"initiatorId": "ghublxbeifhvhwokvhppbw",
"metadata": {
"key9372": "jtc"
}
},
"id": "/subscriptions/11111111-2222-3333-4444-555555555555/resourceGroups/rg1Network/providers/Microsoft.FileShares/fileShares/testfileshare/fileShareSnapshots/testfilesharesnapshot",
"name": "testfilesharesnapshot",
"type": "Microsoft.FileShares/fileShares/fileShareSnapshots",
"systemData": {
"createdBy": "moat",
"createdByType": "User",
"createdAt": "2025-07-23T12:37:53.955Z",
"lastModifiedBy": "dxukcadzapywjcgnxsqchaa",
"lastModifiedByType": "User",
"lastModifiedAt": "2025-07-23T12:37:53.955Z"
}
}
},
"202": {
"headers": {
"location": "https://contoso.com/operationstatus"
Expand Down
38 changes: 26 additions & 12 deletions ...leshares/resource-manager/Microsoft.FileShares/preview/2025-06-01-preview/fileshares.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -760,16 +760,22 @@
}
],
"responses": {
"200": {
"description": "Resource 'FileShareSnapshot' update operation succeeded",
"schema": {
"$ref": "#/definitions/FileShareSnapshot"
}
},
"201": {
"description": "Resource 'FileShareSnapshot' create operation succeeded",
"schema": {
"$ref": "#/definitions/FileShareSnapshot"
"202": {
"description": "Resource operation accepted.",
"headers": {
"Azure-AsyncOperation": {
"type": "string",
"description": "A link to the status monitor"
},
"Location": {
"type": "string",
"description": "The Location header contains the URL where the status of the long running operation can be checked."
},
"Retry-After": {
"type": "integer",
"format": "int32",
"description": "The Retry-After header can indicate how long the client should wait before polling the operation status."
}
}
},
"default": {
Expand All @@ -783,7 +789,11 @@
"FileShareSnapshot_CreateOrUpdate_MaximumSet": {
"$ref": "./examples/FileShareSnapshot_CreateOrUpdate_MaximumSet_Gen.json"
}
}
},
"x-ms-long-running-operation-options": {
"final-state-via": "location"
},
"x-ms-long-running-operation": true
},
"patch": {
"operationId": "FileShareSnapshot_Update",
Expand Down Expand Up @@ -835,8 +845,12 @@
}
},
"202": {
"description": "Resource update request accepted.",
"description": "Resource operation accepted.",
"headers": {
"Azure-AsyncOperation": {
"type": "string",
"description": "A link to the status monitor"
},
"Location": {
"type": "string",
"description": "The Location header contains the URL where the status of the long running operation can be checked."
Expand Down
32 changes: 32 additions & 0 deletions specification/fileshares/resource-manager/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,38 @@ directive:

- $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.FileShares/fileShares/{resourceName}/fileShareSnapshots/{name}"].patch.operationId

- suppress: ProvisioningStateSpecifiedForLROPut

reason: "RP doesn't support 201 Created pattern for proxy resources in public preview. To be addressed in GA."

where:

- $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.FileShares/fileShares/{resourceName}/fileShareSnapshots/{name}"].put

- suppress: ProvisioningStateSpecifiedForLROPatch

reason: "RP doesn't support 201 Created pattern for proxy resources in public preview. To be addressed in GA."

where:

- $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.FileShares/fileShares/{resourceName}/fileShareSnapshots/{name}"].patch

- suppress: PutResponseCodes

reason: "RP doesn't support 201 Created pattern for proxy resources in public preview. To be addressed in GA."

where:

- $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.FileShares/fileShares/{resourceName}/fileShareSnapshots/{name}"].put

- suppress: PutGetPatchResponseSchema

reason: "Cannot support same schema object for PUT/GET/PATCH for proxy object due to 202 response"

where:

- $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.FileShares/fileShares/{resourceName}/fileShareSnapshots/{name}"]

```


Expand Down
Loading