[DO NOT MERGE][AKS] Add new api model#3620
Conversation
Automation for azure-sdk-for-pythonA PR has been created for you: |
Automation for azure-sdk-for-nodeA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
|
Just copy and paste the 2018-03-31 api model and rename it to 2018-03-31-preview. |
Automation for azure-sdk-for-goA PR has been created for you: |
|
Can one of the admins verify this patch? |
| }, | ||
| "type": { | ||
| "type": "string", | ||
| "enum": [ |
There was a problem hiding this comment.
Please use x-ms-enum instead
There was a problem hiding this comment.
We have actually stopped reading this from the customer. We just default to always use VMSS for this api version, on creates, old clusters we treat as not changing from what they are. So we should be able to remove this from the schema.
| "description": "OsType to be used to specify os type. Choose from Linux and Windows. Default to Linux." | ||
| }, | ||
| "maxCount":{ | ||
| "type": "integer", |
There was a problem hiding this comment.
Please check these properties for readonly ness
There was a problem hiding this comment.
The value should be passed by customer, and default value is nil. so we are good here
|
Please don't merge before I do some test. Will let you final review when this PR is ready. |
|
Hi @zqingqing1 will close this PR by EOW if there is no activity. |
|
Please don't close this PR, There is still some work from Laurent to support multi-api, after then, This PR should be good to merge. |
|
@zqingqing1 You can always open a new PR when you are ready to go. We do not recommend keeping PRs open against the repo for too long. |
|
Closing PR due to inactivity. |
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger