Skip to content

[DO NOT MERGE][AKS] Add new api model#3620

Closed
zqingqing1 wants to merge 5 commits intoAzure:masterfrom
zqingqing1:support-two-apiversion
Closed

[DO NOT MERGE][AKS] Add new api model#3620
zqingqing1 wants to merge 5 commits intoAzure:masterfrom
zqingqing1:support-two-apiversion

Conversation

@zqingqing1
Copy link
Member

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Aug 9, 2018

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#3121

@AutorestCI
Copy link

AutorestCI commented Aug 9, 2018

Automation for azure-sdk-for-node

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-node#3304

@AutorestCI
Copy link

AutorestCI commented Aug 9, 2018

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Aug 9, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@zqingqing1
Copy link
Member Author

Just copy and paste the 2018-03-31 api model and rename it to 2018-03-31-preview.

@AutorestCI
Copy link

AutorestCI commented Aug 9, 2018

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#2571

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@zqingqing1 zqingqing1 changed the title Add new api model [AKS] Add new api model Aug 9, 2018
},
"type": {
"type": "string",
"enum": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use x-ms-enum instead

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have actually stopped reading this from the customer. We just default to always use VMSS for this api version, on creates, old clusters we treat as not changing from what they are. So we should be able to remove this from the schema.

"description": "OsType to be used to specify os type. Choose from Linux and Windows. Default to Linux."
},
"maxCount":{
"type": "integer",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check these properties for readonly ness

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value should be passed by customer, and default value is nil. so we are good here

@zqingqing1
Copy link
Member Author

Please don't merge before I do some test. Will let you final review when this PR is ready.

@dsgouda dsgouda added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Aug 10, 2018
@dsgouda dsgouda changed the title [AKS] Add new api model [DO NOT MERGE][AKS] Add new api model Aug 10, 2018
@dsgouda
Copy link
Contributor

dsgouda commented Aug 22, 2018

Hi @zqingqing1 will close this PR by EOW if there is no activity.

@zqingqing1
Copy link
Member Author

Please don't close this PR, There is still some work from Laurent to support multi-api, after then, This PR should be good to merge.

@dsgouda
Copy link
Contributor

dsgouda commented Aug 23, 2018

@zqingqing1 You can always open a new PR when you are ready to go. We do not recommend keeping PRs open against the repo for too long.

@dsgouda
Copy link
Contributor

dsgouda commented Aug 29, 2018

Closing PR due to inactivity.
@zqingqing1 Please open a new PR when you are ready and reference this PR so we can expedite it for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DoNotMerge <valid label in PR review process> use to hold merge after approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments