Skip to content

Comments

[botservice] Modify the optionality of 'location'#36130

Merged
pshao25 merged 4 commits intomainfrom
fix/botservice
Jul 23, 2025
Merged

[botservice] Modify the optionality of 'location'#36130
pshao25 merged 4 commits intomainfrom
fix/botservice

Conversation

@melina5656
Copy link
Member

@melina5656 melina5656 commented Jul 23, 2025 •
edited
Loading

In the previous convert, location property was mistakenly set as required. This PR corrects it to the proper configuration.
convert pr：#34585

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 23, 2025 •
edited
Loading

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 23, 2025 •
edited
Loading

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@github-actions
Copy link

github-actions bot commented Jul 23, 2025 •
edited
Loading

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger Microsoft.BotService
TypeSpec Microsoft.BotService
Go sdk/resourcemanager/botservice/armbotservice
JavaScript @azure/arm-botservice
Java com.azure.resourcemanager:azure-resourcemanager-botservice
Python azure-mgmt-botservice

@AzureRestAPISpecReview AzureRestAPISpecReview added resource-manager TypeSpec Authored with TypeSpec VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required labels Jul 23, 2025
@melina5656 melina5656 marked this pull request as ready for review July 23, 2025 07:12
@v-jiaodi v-jiaodi mentioned this pull request Jul 23, 2025
Closed
@pshao25 pshao25 added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review PublishToCustomers Acknowledgement the changes will be published to Azure customers. Versioning-Approved-Benign https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-LintDiff labels Jul 23, 2025
@pshao25 pshao25 merged commit 9a0877e into main Jul 23, 2025
96 of 100 checks passed
@pshao25 pshao25 deleted the fix/botservice branch July 23, 2025 09:27
Copilot AI mentioned this pull request Oct 29, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pshao25 pshao25 pshao25 approved these changes

Assignees

No one assigned

Labels

Approved-LintDiff ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review NotReadyForARMReview PipelineBotTrigger PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager TypeSpec Authored with TypeSpec Versioning-Approved-Benign https://github.com/Azure/azure-sdk-tools/issues/6374 VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@melina5656 @pshao25 @AzureRestAPISpecReview @v-jiaodi