Skip to content

[maintenance] Modify the optionality of 'location' #36127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pshao25 merged 3 commits into from
Jul 23, 2025
Merged

[maintenance] Modify the optionality of 'location' #36127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
67cf979
Modify the optionality of 'location'
melina5656 Jul 23, 2025
6cb26f3
update
melina5656 Jul 23, 2025
2a678b8
Merge branch 'main' into fix/maintenance
melina5656 Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion specification/maintenance/Maintenance.Management/MaintenanceConfiguration.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,26 @@ namespace Microsoft.Maintenance;
* Maintenance configuration record type
*/
model MaintenanceConfiguration
is Azure.ResourceManager.TrackedResource<MaintenanceConfigurationProperties> {
is Azure.ResourceManager.ProxyResource<MaintenanceConfigurationProperties> {
...ResourceNameParameter<
Resource = MaintenanceConfiguration,
KeyName = "resourceName",
SegmentName = "publicMaintenanceConfigurations",
NamePattern = ""
>;

/**
* Gets or sets location of the resource
*/
#suppress "@azure-tools/typespec-azure-resource-manager/arm-resource-invalid-envelope-property" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
location?: string;

/**
* Gets or sets tags of the resource
*/
#suppress "@azure-tools/typespec-azure-resource-manager/arm-resource-invalid-envelope-property" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
#suppress "@azure-tools/typespec-azure-resource-manager/arm-no-record" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
tags?: Record<string>;
}

@armResourceOperations
Expand Down
13 changes: 12 additions & 1 deletion ...enance/resource-manager/Microsoft.Maintenance/preview/2023-10-01-preview/Maintenance.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2534,11 +2534,22 @@
"$ref": "#/definitions/MaintenanceConfigurationProperties",
"description": "Gets or sets properties of the resource",
"x-ms-client-flatten": true
},
"location": {
"type": "string",
"description": "Gets or sets location of the resource"
},
"tags": {
"type": "object",
"description": "Gets or sets tags of the resource",
"additionalProperties": {
"type": "string"
}
}
},
"allOf": [
{
"$ref": "../../../../../common-types/resource-management/v5/types.json#/definitions/TrackedResource"
"$ref": "../../../../../common-types/resource-management/v5/types.json#/definitions/ProxyResource"
}
]
},
Expand Down
Loading