[EngSys] decouple filters in changed-files.js#36096
Merged
mikeharder merged 44 commits intoAzure:mainfrom Jul 23, 2025
Merged
Conversation
Next Steps to MergeNext steps that must be taken to merge this PR:
|
|
PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
mikeharder
commented
Jul 22, 2025
mikeharder
commented
Jul 22, 2025
mikeharder
commented
Jul 22, 2025
mikeharder
changed the title
scbedd
approved these changes
Jul 22, 2025
scbedd
approved these changes
Jul 22, 2025
raych1
approved these changes
Jul 22, 2025
Member
|
Tests need to be fixed, and the remained part looks good. |
mikeharder
commented
Jul 23, 2025
| vi.clearAllMocks(); | ||
|
|
||
| // Setup default mocks | ||
| mockPath.resolve.mockImplementation((...paths) => paths.join("/")); |
Member
Author
There was a problem hiding this comment.
@raych1: These mocks broke tests in this PR on Windows, and I think they should be unnecessary, because the runtime implementation should work even in tests, on all OS.
mikeharder
changed the title
mikeharder
changed the title
Next Steps to Merge⌛ Please wait. Next steps to merge this PR are being evaluated by automation. ⌛Comment generated by summarize-checks workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
specification()is removedpaths: ["specification"]togetChangedFiles()getChangedFiles()to return absolute platform pathse2e test for impacted checks: mikeharder#26