Skip to content

[spec-model] Remove duplicate copy of readme() #36095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikeharder merged 1 commit into from
Jul 22, 2025
Merged

[spec-model] Remove duplicate copy of readme() #36095

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions .github/shared/src/spec-model.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
// @ts-check

import { readdir } from "fs/promises";
import { resolve } from "path";
import { flatMapAsync, mapAsync } from "./array.js";
import { readme } from "./changed-files.js";
import { Readme } from "./readme.js";

/** @type {Map<string, SpecModel>} */
Expand Down Expand Up @@ -226,14 +227,3 @@
return `SpecModel(${this.#folder}, {logger: ${this.#logger}}})`;
}
}

// TODO: Remove duplication with changed-files.js (which currently requires paths relative to repo root)

/**
Copy link
Member Author

@mikeharder mikeharder Jul 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy in changed-files was identical:

azure-rest-api-specs/.github/shared/src/changed-files.js

Lines 146 to 153 in 2ae7cdd

/**
* @param {string} [file]
* @returns {boolean}
*/
export function readme(file) {
// Filename "readme.md" with any case is a valid README file
return typeof file === "string" && file.toLowerCase().endsWith("readme.md");
}

* @param {string} [file]
* @returns {boolean}
*/
function readme(file) {
// Filename "readme.md" with any case is a valid README file
return typeof file === "string" && file.toLowerCase().endsWith("readme.md");
}
Loading