[AKS]modify credentialResults keyName to kubeconfigs#3606
[AKS]modify credentialResults keyName to kubeconfigs#3606anuchandy merged 1 commit intoAzure:masterfrom
Conversation
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-nodeThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
|
Can one of the admins verify this patch? |
| "CredentialResults":{ | ||
| "properties": { | ||
| "values": { | ||
| "kubeconfigs": { |
There was a problem hiding this comment.
Changing property name of payload model in a stable api version is breaking change. Requesting ARM feedback here.
There was a problem hiding this comment.
I made a mistake before, it should be 'kubeconfigs'. It is not a breaking change.
There was a problem hiding this comment.
had a chat with @zqingqing1, 'kubeconfigs' is the name of the property from the beginning and usage of the property name "values" is a error in the swagger authoring. This PR simply fix this error.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger