Adding new public preview version 2025-05-03-preview for Microsoft.Monitor/Accounts#35968
Conversation
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
|
PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
- Add readme.python.md for Python SDK generation - Add readme.java.md for Java SDK generation - Update readme.md to reference language-specific configurations - Fixes 'python_readme' undefined error in SDK automation
- Add documentation comment for azure-libraries-for-java-folder usage - Clean up tspconfig.yaml to remove unused SDK emitter configurations - Update Python readme structure to follow Azure standards These changes improve SDK generation compatibility and follow Azure documentation guidelines.
| /** | ||
| * Flag that indicates whether to enable access using resource permissions. | ||
| */ | ||
| enableAccessUsingResourcePermissions?: boolean; |
There was a problem hiding this comment.
Consider changing this to an enum. For example, accessMode with 'Default' and 'UsingResourcePermission'. This allows more values in the future without introducing more boolean properties.
There was a problem hiding this comment.
Currently there is a property named "enableLogAccessUsingOnlyResourcePermissions" in LogAnalyticsWorkspace which is similar to this: https://learn.microsoft.com/en-us/rest/api/loganalytics/workspaces/create-or-update?view=rest-loganalytics-2025-02-01&tabs=HTTP#workspacefeatures
Represented the same behavior in AzureMonitorWorkspace so it becomes easier for the customers to associate this property across the Azure monitor resources. Please see if this can be similar.
| "defaultIngestionSettings": { | ||
| "dataCollectionRuleResourceId": "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/MA_myAzureMonitorWorkspace_eastus_managed/providers/Microsoft.Insights/dataCollectionRules/myAzureMonitorWorkspace", | ||
| "dataCollectionEndpointResourceId": "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/MA_myAzureMonitorWorkspace_eastus_managed/providers/Microsoft.Insights/dataCollectionEndpoints/myAzureMonitorWorkspace", | ||
| "dataCollectionRuleImmutableId": "tduhxnyxactsorrwqavxegaoavari", |
There was a problem hiding this comment.
Yeah, Fixed it. Thanks for the catch!
|
Can you fix the TypeSpec Validation failure? Everything else looks good. |
…nitor/accounts
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PRandDue diligence checklist.write accessper aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.