Skip to content

Adding new public preview version 2025-05-03-preview for Microsoft.Monitor/Accounts#35968

Merged
GokulPrasad-Work merged 23 commits intomainfrom
release-accounts-Microsoft.Monitor/2023-04-03
Jul 25, 2025
Merged

Adding new public preview version 2025-05-03-preview for Microsoft.Monitor/Accounts#35968
GokulPrasad-Work merged 23 commits intomainfrom
release-accounts-Microsoft.Monitor/2023-04-03

Conversation

@GokulPrasad-Work
Copy link
Member

…nitor/accounts

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
  • A release plan has been created. If not, please create one as it will help guide you through the REST API and SDK creation process.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.
  • For guidance on SDK breaking change review, refer to https://aka.ms/ci-fix.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 17, 2025

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 17, 2025

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Monitor Monitor, Monitor Ingestion, Monitor Query label Jul 17, 2025
@github-actions
Copy link

github-actions bot commented Jul 17, 2025

@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview new-api-version resource-manager RPaaS TypeSpec Authored with TypeSpec WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 17, 2025
GokulPrasad-Work and others added 9 commits July 23, 2025 08:49
- Add readme.python.md for Python SDK generation
- Add readme.java.md for Java SDK generation
- Update readme.md to reference language-specific configurations
- Fixes 'python_readme' undefined error in SDK automation
- Add documentation comment for azure-libraries-for-java-folder usage
- Clean up tspconfig.yaml to remove unused SDK emitter configurations
- Update Python readme structure to follow Azure standards

These changes improve SDK generation compatibility and follow Azure documentation guidelines.
/**
* Flag that indicates whether to enable access using resource permissions.
*/
enableAccessUsingResourcePermissions?: boolean;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider changing this to an enum. For example, accessMode with 'Default' and 'UsingResourcePermission'. This allows more values in the future without introducing more boolean properties.

Copy link
Member Author

@GokulPrasad-Work GokulPrasad-Work Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently there is a property named "enableLogAccessUsingOnlyResourcePermissions" in LogAnalyticsWorkspace which is similar to this: https://learn.microsoft.com/en-us/rest/api/loganalytics/workspaces/create-or-update?view=rest-loganalytics-2025-02-01&tabs=HTTP#workspacefeatures
Represented the same behavior in AzureMonitorWorkspace so it becomes easier for the customers to associate this property across the Azure monitor resources. Please see if this can be similar.

"defaultIngestionSettings": {
"dataCollectionRuleResourceId": "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/MA_myAzureMonitorWorkspace_eastus_managed/providers/Microsoft.Insights/dataCollectionRules/myAzureMonitorWorkspace",
"dataCollectionEndpointResourceId": "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/MA_myAzureMonitorWorkspace_eastus_managed/providers/Microsoft.Insights/dataCollectionEndpoints/myAzureMonitorWorkspace",
"dataCollectionRuleImmutableId": "tduhxnyxactsorrwqavxegaoavari",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tduhxnyxactsorrwqavxegaoavari

Should be a guid, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, Fixed it. Thanks for the catch!

@gary-x-li
Copy link
Contributor

Can you fix the TypeSpec Validation failure? Everything else looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved-Suppression ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review Monitor Monitor, Monitor Ingestion, Monitor Query new-api-version PipelineBotTrigger PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager RPaaS SuppressionReviewRequired TypeSpec Authored with TypeSpec

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants