Added mongocluster api version 2025-05-01-preview#35754
Added mongocluster api version 2025-05-01-preview#35754joelpineiro wants to merge 6 commits intomainfrom
Conversation
Next Steps to MergeNext steps that must be taken to merge this PR:
|
|
PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the new Mongo Cluster ARM API version 2025-05-01-preview. It updates the global readme tag, adds a corresponding TypeSpec version enum, defines a basic end-to-end scenario, and supplies a full set of OpenAPI examples for the new preview release.
- Update ARM readme to include
package-2025-05-01-preview - Register
v2025_05_01_previewin TypeSpecVersionsenum - Add basic API scenario and dozens of new example JSONs under the preview folder
Reviewed Changes
Copilot reviewed 78 out of 79 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| specification/mongocluster/resource-manager/readme.md | Bumped ARM tag to 2025-05-01-preview and added its conditional input-file block |
| specification/mongocluster/resource-manager/Microsoft.DocumentDB/preview/2025-05-01-preview/scenarios/basic.yaml | Added the “basic” API scenario covering create/read/update/delete flows |
| specification/mongocluster/DocumentDB.MongoCluster.Management/main.tsp | Introduced v2025_05_01_preview into the Versions enum |
| specification/mongocluster/resource-manager/Microsoft.DocumentDB/preview/2025-05-01-preview/examples/... | Added full set of operation examples for the new preview version |
Comments suppressed due to low confidence (3)
specification/mongocluster/resource-manager/Microsoft.DocumentDB/preview/2025-05-01-preview/scenarios/basic.yaml:89
- The JSON path here does not match the ResetPassword example—there is no
administratorLoginPasswordproperty under/properties/properties. It should target/properties/properties/administrator/password(or include theresourcesegment if needed) to update the administrator’s password correctly.
- replace: /properties/properties/administratorLoginPassword
specification/mongocluster/resource-manager/Microsoft.DocumentDB/preview/2025-05-01-preview/examples/MongoClusters_PrivateEndpointConnectionPut.json:14
- [nitpick] The request example uses
"description": "Auto-Approved", but the corresponding response shows"Auto-approved"(lowercase "a") and"Approved by admin". Consider standardizing the case and phrasing to avoid confusion.
"description": "Auto-Approved"
specification/mongocluster/resource-manager/Microsoft.DocumentDB/preview/2025-05-01-preview/scenarios/basic.yaml:124
- [nitpick] Using
_2in the step name is not descriptive. Consider renaming to something likeMongoClusters_ForcePromotePrimaryorMongoClusters_DemoteOldReplicato clarify its intent.
- step: MongoClusters_ForcePromoteReplica_2
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
|
|
@microsoft-github-policy-service agree company="Microsoft" |
…ps://github.com/Azure/azure-rest-api-specs into users/jpineiro/mongoclusters_2025_05_01_preview
|
Superseded by #35802 which adds CMK support in 2025-07-01-preview. We will not be releasing 2025-05-01-preview. |
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PRandDue diligence checklist.write accessper aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.