Merged
Conversation
Next Steps to Merge⌛ Please wait. Next steps to merge this PR are being evaluated by automation. ⌛ |
|
PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
github-actions
bot
added
the
brownfield
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
Prakriti-nith
force-pushed
the
users/prakgupta/metrics-fw-copy
branch
from
e702f69 to
4a1dd5d
Compare
AzureRestAPISpecReview
added
ARMReview
new-api-version
resource-manager
RPaaS
WaitForARMFeedback
Contributor
|
Fix the Lintdiff errors and then remove |
openapi-pipeline-app
bot
removed
the
WaitForARMFeedback
AzureRestAPISpecReview
added
BreakingChangeReviewRequired
openapi-pipeline-app
bot
added
the
WaitForARMFeedback
Prakriti-nith
added
the
PublishToCustomers
AzureRestAPISpecReview
removed
the
WaitForARMFeedback
Prakriti-nith
force-pushed
the
users/prakgupta/metrics-fw-copy
branch
from
73330f8 to
6de8e8b
Compare
Prakriti-nith
commented
Jul 17, 2025
| "in": "path", | ||
| "required": true, | ||
| "description": "Firewall resource name", | ||
| "pattern": "^[a-zA-Z0-9](?:[a-zA-Z0-9-]*[a-zA-Z0-9])?$", |
Member
Author
There was a problem hiding this comment.
Breaking change is happening due to this pattern on firewall resource name. This was required to fix a lint check which mentioned that this name should follow a pattern.
This pattern indicates that name can contain alphanumeric characters along with a hyphen and hyphen should not occur at the beginning and end of the name.
This check is already there in code.
JeffreyRichter
added
the
BreakingChange-Approved-Benign
Member
Author
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
AzureRestAPISpecReview
added
WaitForARMFeedback
krisnaray
added
the
ARMSignedOff
openapi-pipeline-app
bot
removed
the
WaitForARMFeedback
krisnaray
approved these changes
Jul 23, 2025
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Choose a PR Template
Switch to "Preview" on this description then select one of the choices below.
Click here to open a PR for a Data Plane API.
Click here to open a PR for a Control Plane (ARM) API.
Click here to open a PR for only SDK configuration.