add location tabs to heatmap bottom view port #3559

yuncmsft · 2018-07-31T22:37:43Z

need to add three location tabs to heatmap bottom view port (currently one table showing all source IPs/query counts). * discussion and feedback needed *

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

need to add three location tabs to heatmap bottom view port (currently one table showing all source IPs/query counts).

azuresdkci · 2018-07-31T22:37:45Z

Can one of the admins verify this patch?

AutorestCI · 2018-07-31T22:38:11Z

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout c1b4577f9fec6f9274e5a7b9d7c026898f04ce8f
  stderr: 'fatal: reference is not a tree: c1b4577f9fec6f9274e5a7b9d7c026898f04ce8f'

AutorestCI · 2018-07-31T22:38:37Z

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#3275

AutorestCI · 2018-07-31T22:38:39Z

Automation for azure-sdk-for-ruby

Encountered an unknown error: (azure-sdk-for-ruby)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout c1b4577f9fec6f9274e5a7b9d7c026898f04ce8f
  stderr: 'fatal: reference is not a tree: c1b4577f9fec6f9274e5a7b9d7c026898f04ce8f'

AutorestCI · 2018-07-31T22:38:46Z

Automation for azure-sdk-for-java

Encountered an unknown error: (azure-sdk-for-java)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout c1b4577f9fec6f9274e5a7b9d7c026898f04ce8f
  stderr: 'fatal: reference is not a tree: c1b4577f9fec6f9274e5a7b9d7c026898f04ce8f'

AutorestCI · 2018-07-31T22:39:46Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout c1b4577f9fec6f9274e5a7b9d7c026898f04ce8f
  stderr: 'fatal: reference is not a tree: c1b4577f9fec6f9274e5a7b9d7c026898f04ce8f'

[change type to number] Need to add three location tabs under current Traffic Manager Heatmap view port. [discussion and feedback needed]

in addition to default heatmap table, add three location options

msftclas · 2018-08-01T00:27:09Z

All CLA requirements met.

lmazuel · 2018-08-01T15:53:17Z

...tion/trafficmanager/resource-manager/Microsoft.Network/stable/2018-04-01/trafficmanager.json

            "required": true,
            "type": "string",
            "enum": [
              "default"


Missing comma

missing comma for heatMapType enum.

an JSON example to reuse heatmap for heatMapLocation: [Azure/azure-rest-api-specs] add location tabs to heatmap bottom view port (Azure#3559)

add HeatMapPropertyBase and four sub-classes: default, asn, country, state; add links to JSON examples update HeatMapModel

example of HeatMapCountry GET (heapMapType == "country")

example for HeatMapASN GET responses (heatMapType =="asn")

an example for HeatMapState GET response (heatMapType == "state")

lmazuel · 2018-08-03T16:10:26Z

...tion/trafficmanager/resource-manager/Microsoft.Network/stable/2018-04-01/trafficmanager.json

+        "heatMapType"
+      ],
+    },
+    "default":{


Use a meaingful name, and the x-ms-discriminator-value for the real value. Example:

"DatasetBZip2Compression": { "x-ms-discriminator-value": "BZip2",

This means "Create class DatasetBZip2Compression, but match value BZip2 on the wire"

I see. so here I can use
"HeatMapPropertyAsn":
{"x-ms-discriminator-value": "asn",
to indicate that when heatMapType=="asn", the HeatMapPropertyAsn will be applied?
if so, that's very convenient - I was very confused how I can link the two.

lmazuel · 2018-08-03T16:10:41Z

...tion/trafficmanager/resource-manager/Microsoft.Network/stable/2018-04-01/trafficmanager.json

+        }
+      ]
+    },
+    "asn":{


Use a meaingful name, and the x-ms-discriminator-value for the real value. Example:

"DatasetBZip2Compression": { "x-ms-discriminator-value": "BZip2",

This means "Create class DatasetBZip2Compression, but match value BZip2 on the wire"

lmazuel · 2018-08-03T16:10:47Z

...tion/trafficmanager/resource-manager/Microsoft.Network/stable/2018-04-01/trafficmanager.json

+        }
+      ]
+    },
+    "country":{


Use a meaningful name, and the x-ms-discriminator-value for the real value. Example:

"DatasetBZip2Compression": { "x-ms-discriminator-value": "BZip2",

This means "Create class DatasetBZip2Compression, but match value BZip2 on the wire"

lmazuel · 2018-08-03T16:12:23Z

...tion/trafficmanager/resource-manager/Microsoft.Network/stable/2018-04-01/trafficmanager.json

+      },
+      "required": [
+        "heatMapType"
+      ],


Extra comma, invalid JSON

lmazuel · 2018-08-03T16:12:44Z

...tion/trafficmanager/resource-manager/Microsoft.Network/stable/2018-04-01/trafficmanager.json

-      "description": "Class representing a Traffic Manager HeatMap properties."
+      ]        
+    },
+    "state":{


Use a meaningful name, and the x-ms-discriminator-value for the real value. Example:

"DatasetBZip2Compression": { "x-ms-discriminator-value": "BZip2",

This means "Create class DatasetBZip2Compression, but match value BZip2 on the wire"

lmazuel · 2018-08-03T16:13:25Z

...tion/trafficmanager/resource-manager/Microsoft.Network/stable/2018-04-01/trafficmanager.json

      },
      "description": "Class which is a sparse representation of a Traffic Manager endpoint."
    },
+    "HeatMapLocation": {


Now you split everything, this type should be used somewhere.

ar... forgot to update this def name, should be "TrafficLocation" - i'm assuming when I use "$ref": "#/definitions/TrafficLocation", this "TrafficLocation" will be applied.

"default" -> HeatMapProperties "asn" -> HeatMapPropertyAsn "country" -> HeatMapPropertyCountry "state" -> HeatMapPropertyState rename HeatMapLocation to TrafficLocation (referenced)

update resource type name

update resource type

update discriminator value to be resource type

ravbhatnagar

some noticeable issues. Lets close over a quick call. I want to make sure service is doing the right thing here.

ravbhatnagar · 2018-08-06T18:32:57Z

...cmanager/resource-manager/Microsoft.Network/stable/2018-04-01/examples/HeatMapState-GET.json

+  "responses": {
+    "200": {
+      "body": {
+        "id": "/subscriptions/{subscription-id}/resourceGroups/azuresdkfornetautoresttrafficmanager1323/providers/Microsoft.Network/trafficManagerProfiles/azuresdkfornetautoresttrafficmanager3880/heatMaps/stateTrafficFraction",


name value coming from "id" does not match the value in "name" property. Please make sure service returns the correct "id" and "name" value

updated name and type - do we need a separate API version?

ravbhatnagar · 2018-08-06T18:34:06Z

...anager/resource-manager/Microsoft.Network/stable/2018-04-01/examples/HeatMapCountry-GET.json

+      "body": {
+        "id": "/subscriptions/{subscription-id}/resourceGroups/azuresdkfornetautoresttrafficmanager1323/providers/Microsoft.Network/trafficManagerProfiles/azuresdkfornetautoresttrafficmanager3880/heatMaps/countryTrafficFraction",
+        "name": "country",
+        "type": "Microsoft.Network/trafficManagerProfiles/heatMaps/countryTrafficFraction",


name, id, type values are all messed up. Please set up a sync with armapireview to get this approved.

ravbhatnagar · 2018-08-15T07:42:38Z

LOoks like you have decided to go with enum for heatmap type with fixed set of names that can be given instead of $expand. Looks fine to me.

lmazuel · 2018-08-15T17:04:12Z

...tion/trafficmanager/resource-manager/Microsoft.Network/stable/2018-04-01/trafficmanager.json

-    "HeatMapProperties": {
+    "HeatMapPropertyBase": {
+      "type": "object",
+      "discriminator": "heatMapType",


That's not exactly the way to do it, but we're close :)

HeatMapModel should declare id, name, and type and nothing more

HeatMapModel should have the discriminator on "type", since this is the actual value that discriminates (heatMapType does not exist in the JSON).

For each type, you need two classes (take Country as example)

HeatMapModelCountry that is a allOf of HeatMapModel and has the x-discriminator-value, and contains one node properties described in a class HeatMapModelCountryProperties. This last one does not talk about discriminator

Hope this clarify a bit, it's easier to see now we made progress and have examples.

- Include ARM's comments to update name, and type. - Swagger discriminator now uses 'name' as distinguisher: "default", "asnTrafficFraction", "countryTrafficFraction", "stateTrafficFraction". - Updated existing HeatMapModel to be the super class with four dervatives with a discriminator value in each class: HeatMapModelDefault, HeatMaptModelAsn, HeatMapModelCountry, HeatMapModelState. - Each sub-model has a corresponding properties class

remove extra comma

salameer · 2019-04-04T17:56:50Z

@lmazuel do you recall what's the deal with this one? should it be merged?

salameer · 2019-04-05T23:55:32Z

ping @lmazuel :)

dsgouda

Looks good for the most part

dsgouda · 2019-04-08T16:54:43Z

...tion/trafficmanager/resource-manager/Microsoft.Network/stable/2018-04-01/trafficmanager.json

      "description": "Class which is a sparse representation of a Traffic Manager endpoint."
    },
+    "TrafficLocation": {
+      "properties": {


Please mark the readonly properties wherever applicable

salameer · 2019-04-11T18:24:21Z

@yuncmsft can you please address the changes requested?

salameer · 2019-04-23T20:48:56Z

CLosing since there's no response from @yuncmsft please request to reopen if required

AutorestCI · 2019-04-23T20:49:53Z

Automation for azure-sdk-for-js

Encountered an unknown error: (azure-sdk-for-js)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout c1b4577f9fec6f9274e5a7b9d7c026898f04ce8f
  stderr: 'fatal: reference is not a tree: c1b4577f9fec6f9274e5a7b9d7c026898f04ce8f'

add location tabs to heatmap bottom view port

2174cac

need to add three location tabs to heatmap bottom view port (currently one table showing all source IPs/query counts).

azuresdkci assigned lmazuel Jul 31, 2018

azuresdkci requested a review from lmazuel July 31, 2018 22:49

add location tabs to heatmap bottom view port

a706188

[change type to number] Need to add three location tabs under current Traffic Manager Heatmap view port. [discussion and feedback needed]

add location tabs to heatmap bottom view port

b60d33f

in addition to default heatmap table, add three location options

lmazuel requested changes Aug 1, 2018

View reviewed changes

add location tabs to heatmap bottom view port

82a6d30

missing comma for heatMapType enum.

yuncmsft mentioned this pull request Aug 1, 2018

JSON example for GET heatMapLocation (PR#3559) #3566

Closed

10 tasks

yuncmsft added 4 commits August 2, 2018 17:20

add location tabs to heatmap bottom view port

9bda23c

add HeatMapPropertyBase and four sub-classes: default, asn, country, state; add links to JSON examples update HeatMapModel

HeatMapCountry-GET.json

c096c89

example of HeatMapCountry GET (heapMapType == "country")

create HeatMapAsn-GET.json

a2ea428

example for HeatMapASN GET responses (heatMapType =="asn")

create HeatMapState-GET.json

af0613f

an example for HeatMapState GET response (heatMapType == "state")

lmazuel reviewed Aug 3, 2018

View reviewed changes

update x-ms-discriminator-value

8e57d4b

"default" -> HeatMapProperties "asn" -> HeatMapPropertyAsn "country" -> HeatMapPropertyCountry "state" -> HeatMapPropertyState rename HeatMapLocation to TrafficLocation (referenced)

lmazuel requested a review from ravbhatnagar August 3, 2018 23:06

lmazuel added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 3, 2018

yuncmsft added 4 commits August 3, 2018 16:42

Update HeatMapAsn-GET.json

03c6279

update resource type name

Update HeatMapCountry-GET.json

c81fcab

update resource type

Update HeatMapState.json

1d135ab

update resource type

update x-ms-discriminator-value to type

00ea355

update discriminator value to be resource type

ravbhatnagar reviewed Aug 6, 2018

View reviewed changes

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 15, 2018

lmazuel reviewed Aug 15, 2018

View reviewed changes

update example id/name/type

feaf930

AutorestCI mentioned this pull request Aug 15, 2018

[AutoPR trafficmanager/resource-manager] add location tabs to heatmap bottom view port Azure/azure-sdk-for-ruby#1580

Closed

yuncmsft and others added 5 commits August 15, 2018 10:52

update example id/name/type

b115fde

update example id/name/type

4892e88

remove extra comma

5d5c098

remove extra comma

Add generate-empty-classes

c2d87c5

lmazuel added the Reassign label Dec 21, 2018

azuresdkci removed the Reassign label Dec 22, 2018

azuresdkci assigned dsgouda and unassigned lmazuel Dec 22, 2018

azuresdkci requested a review from dsgouda December 22, 2018 00:33

dsgouda suggested changes Apr 8, 2019

View reviewed changes

salameer closed this Apr 23, 2019

add location tabs to heatmap bottom view port #3559

add location tabs to heatmap bottom view port #3559

Uh oh!

Conversation

yuncmsft commented Jul 31, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR information

Quality of Swagger

Uh oh!

azuresdkci commented Jul 31, 2018

Uh oh!

AutorestCI commented Jul 31, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Jul 31, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

AutorestCI commented Jul 31, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented Jul 31, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

AutorestCI commented Jul 31, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

msftclas commented Aug 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lmazuel Aug 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ravbhatnagar left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ravbhatnagar commented Aug 15, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

salameer commented Apr 4, 2019

Uh oh!

salameer commented Apr 5, 2019

Uh oh!

dsgouda left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

salameer commented Apr 11, 2019

Uh oh!

salameer commented Apr 23, 2019

Uh oh!

yuncmsft commented Jul 31, 2018 •

edited

Loading

AutorestCI commented Jul 31, 2018 •

edited

Loading

AutorestCI commented Jul 31, 2018 •

edited

Loading

AutorestCI commented Jul 31, 2018 •

edited

Loading

AutorestCI commented Jul 31, 2018 •

edited

Loading

AutorestCI commented Jul 31, 2018 •

edited

Loading

msftclas commented Aug 1, 2018 •

edited

Loading

lmazuel Aug 3, 2018 •

edited

Loading

AutorestCI commented Apr 23, 2019 •

edited

Loading