-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Adding new 2025-06-05 stable version to Diagnostic RP for Spot Placement Scores APIs #35560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
69 commits
Select commit
Hold shift + click to select a range
b9d0d59
Initial - adding new 2025-06-01 stable version to Diagnostic RP. Only…
Elina-L bdc8cbe
Run npx prettier on on GetSpotPlacementScores
Elina-L d9cac72
Merge branch 'main' into wenxliu/CDRPNewAPIVersion20250601
Elina-L 9b2d327
Merge branch 'main' into wenxliu/CDRPNewAPIVersion20250601
Elina-L 2c676de
Merge branch 'main' into wenxliu/CDRPNewAPIVersion20250601
Elina-L 3b3bb32
Changing subscription id to all zeros and changing request ids to sam…
Elina-L a6e4e86
Adding suppression to DiagnosticRP/preview/2025-06-01/**/*.json
Elina-L 4a0d313
Merge branch 'main' into wenxliu/CDRPNewAPIVersion20250601
Elina-L f12f7c0
Change suppressions path to stable instead of preview
Elina-L 3cfc4e5
Merge branch 'wenxliu/CDRPNewAPIVersion20250601' of https://github.co…
Elina-L ff7a733
Merge branch 'main' into wenxliu/CDRPNewAPIVersion20250601
Elina-L ed0b31e
Merge branch 'main' into wenxliu/CDRPNewAPIVersion20250601
Elina-L 9c4450b
Merge branch 'main' into wenxliu/CDRPNewAPIVersion20250601
Elina-L 6faaf09
Merge branch 'main' into wenxliu/CDRPNewAPIVersion20250601
Elina-L 942d47d
Remove redundant property definitions and updating the description co…
Elina-L 3b2225a
Merge branch 'wenxliu/CDRPNewAPIVersion20250601' of https://github.co…
Elina-L 36389f5
Update description for availabilityZone
Elina-L df2f624
Remove H/M/L from placement score description comment
Elina-L ebdc439
Merge branch 'main' into wenxliu/CDRPNewAPIVersion20250601
Elina-L 4da3160
Merge branch 'main' into wenxliu/CDRPNewAPIVersion20250601
Elina-L 22458de
Merge branch 'main' into wenxliu/CDRPNewAPIVersion20250601
Elina-L fcc43c0
Remove ProxyResource from ComputeRP/stable/2024-11-01/computeRPCommon…
Elina-L 14055af
Merge branch 'wenxliu/CDRPNewAPIVersion20250601' of https://github.co…
Elina-L 7528892
Merge branch 'main' into wenxliu/CDRPNewAPIVersion20250601
Elina-L c0fc5ab
Merge branch 'wenxliu/CDRPNewAPIVersion20250601' of https://github.co…
Elina-L 7e7909d
Reference local ProxyResource in diagnostic.json
Elina-L df4848b
Merge branch 'main' into wenxliu/CDRPNewAPIVersion20250601
Elina-L 1e421b0
Fix allref reference path to ProxyResource
Elina-L ac2b55c
Merge branch 'main' into wenxliu/CDRPNewAPIVersion20250601
Elina-L 6de83c3
Merge branch 'main' into wenxliu/CDRPNewAPIVersion20250601
Elina-L 0fee86d
Merge branch 'main' into wenxliu/CDRPNewAPIVersion20250601
Elina-L 6eb2d4f
Adding type: object to fix lint error
Elina-L c004693
Run prettier on diagnostic.json file
Elina-L 3456eb9
Merge branch 'main' into wenxliu/CDRPNewAPIVersion20250601
Elina-L bbb4bb0
Merge branch 'main' into wenxliu/CDRPNewAPIVersion20250601
Elina-L 9b19c5b
Merge branch 'main' into wenxliu/CDRPNewAPIVersion20250601
Elina-L d8c2f92
Merge branch 'main' into wenxliu/CDRPNewAPIVersion20250601
mikeharder 4c258de
Update version number from 2025-06-01 to 2025-06-05 to comply with CP…
Elina-L f493f33
Change suppressions yaml version number
Elina-L c49524f
Merge branch 'main' into wenxliu/CDRPNewAPIVersion20250601
Elina-L 90ab465
Merge branch 'main' into wenxliu/CDRPNewAPIVersion20250601
Elina-L 0dae791
Merge branch 'main' into wenxliu/CDRPNewAPIVersion20250601
Elina-L 0c4762f
Merge branch 'main' into wenxliu/CDRPNewAPIVersion20250601
Elina-L 1e13433
Move package-2025-06-05 tags up
Elina-L f7e5d84
Merge branch 'wenxliu/CDRPNewAPIVersion20250601' of https://github.co…
Elina-L 08fc70a
Changing file to use ComputeRP.json
Elina-L b2f6deb
Change ref to DiskRP.json
Elina-L f2ce517
Merge branch 'main' into wenxliu/CDRPNewAPIVersion20250601
Elina-L 60f85d5
Change ref to GalleryRP.json
Elina-L 22b1bf8
Merge branch 'wenxliu/CDRPNewAPIVersion20250601' of https://github.co…
Elina-L 1fb4866
Merge branch 'main' into wenxliu/CDRPNewAPIVersion20250601
Elina-L 82a4297
Removing v1/common.json ref from readme.md
Elina-L 484c758
Merge branch 'wenxliu/CDRPNewAPIVersion20250601' of https://github.co…
Elina-L cf90ab3
Merge branch 'main' into wenxliu/CDRPNewAPIVersion20250601
Elina-L 68868d4
Change to 2025-01-02 DiskRP ref
Elina-L 1950c9a
Merge branch 'wenxliu/CDRPNewAPIVersion20250601' of https://github.co…
Elina-L e6d50d0
Merge branch 'main' into wenxliu/CDRPNewAPIVersion20250601
Elina-L b22bd07
Removing ProxyResource from diagnostic.json
Elina-L b941103
Run prettier on diagnostic.json
Elina-L b12baac
Merge branch 'main' into wenxliu/CDRPNewAPIVersion20250601
Elina-L fc76b25
Merge branch 'main' into wenxliu/CDRPNewAPIVersion20250601
Elina-L 017fbc7
Adding Microsoft.Compute/common-types/v5/common.json to package-2025-…
Elina-L ba9fa44
Change it to v1 instead
Elina-L c9d3ca1
Change ComputeRP.json refs from v3 to v5
Elina-L b9d4b39
Change everything back to v3
Elina-L ac207c2
Merge branch 'main' into wenxliu/CDRPNewAPIVersion20250601
Elina-L 8b5dc15
Merge branch 'main' into wenxliu/CDRPNewAPIVersion20250601
Elina-L 30da840
Merge branch 'main' into wenxliu/CDRPNewAPIVersion20250601
Elina-L e250a97
Merge branch 'main' into wenxliu/CDRPNewAPIVersion20250601
Elina-L File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
255 changes: 255 additions & 0 deletions
255
...compute/resource-manager/Microsoft.Compute/DiagnosticRP/stable/2025-06-05/diagnostic.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,255 @@ | ||
| { | ||
| "swagger": "2.0", | ||
| "info": { | ||
| "title": "ComputeDiagnosticResourceProviderClient", | ||
| "description": "The Compute Diagnostic Resource Provider Client", | ||
| "version": "2025-06-05" | ||
| }, | ||
| "host": "management.azure.com", | ||
| "schemes": [ | ||
| "https" | ||
| ], | ||
| "consumes": [ | ||
| "application/json" | ||
| ], | ||
| "produces": [ | ||
| "application/json" | ||
| ], | ||
| "security": [ | ||
| { | ||
| "azure_auth": [ | ||
| "user_impersonation" | ||
| ] | ||
| } | ||
| ], | ||
| "securityDefinitions": { | ||
| "azure_auth": { | ||
| "type": "oauth2", | ||
| "authorizationUrl": "https://login.microsoftonline.com/common/oauth2/authorize", | ||
| "flow": "implicit", | ||
| "description": "Azure Active Directory OAuth2 Flow", | ||
| "scopes": { | ||
| "user_impersonation": "impersonate your user account" | ||
| } | ||
| } | ||
| }, | ||
| "paths": { | ||
| "/subscriptions/{subscriptionId}/providers/Microsoft.Compute/locations/{location}/placementScores/spot": { | ||
| "get": { | ||
| "tags": [ | ||
| "placementScores_spot" | ||
| ], | ||
| "operationId": "SpotPlacementScores_Get", | ||
| "description": "Gets Spot Placement Scores metadata.", | ||
| "parameters": [ | ||
| { | ||
| "$ref": "../../../../../../common-types/resource-management/v3/types.json#/parameters/SubscriptionIdParameter" | ||
| }, | ||
| { | ||
| "$ref": "../../../../../../common-types/resource-management/v3/types.json#/parameters/LocationParameter" | ||
| }, | ||
| { | ||
| "$ref": "../../../../../../common-types/resource-management/v3/types.json#/parameters/ApiVersionParameter" | ||
| } | ||
| ], | ||
| "responses": { | ||
| "200": { | ||
| "description": "Success", | ||
| "schema": { | ||
| "$ref": "#/definitions/ComputeDiagnosticBase" | ||
| } | ||
| }, | ||
| "default": { | ||
| "description": "Error response describing why the get call failed.", | ||
| "schema": { | ||
| "$ref": "../../../../../../common-types/resource-management/v3/types.json#/definitions/ErrorResponse" | ||
| } | ||
| } | ||
| }, | ||
| "x-ms-examples": { | ||
| "Gets the metadata of Spot Placement Scores.": { | ||
| "$ref": "./examples/GetSpotPlacementScores.json" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "/subscriptions/{subscriptionId}/providers/Microsoft.Compute/locations/{location}/placementScores/spot/generate": { | ||
| "post": { | ||
| "tags": [ | ||
| "spotPlacementScores" | ||
| ], | ||
| "operationId": "SpotPlacementScores_Post", | ||
| "description": "Generates placement scores for Spot VM skus.", | ||
| "parameters": [ | ||
| { | ||
| "$ref": "../../../../../../common-types/resource-management/v3/types.json#/parameters/SubscriptionIdParameter" | ||
| }, | ||
| { | ||
| "$ref": "../../../../../../common-types/resource-management/v3/types.json#/parameters/LocationParameter" | ||
| }, | ||
| { | ||
| "$ref": "../../../../../../common-types/resource-management/v3/types.json#/parameters/ApiVersionParameter" | ||
| }, | ||
| { | ||
| "name": "spotPlacementScoresInput", | ||
| "in": "body", | ||
| "required": true, | ||
| "schema": { | ||
| "$ref": "#/definitions/SpotPlacementScoresInput" | ||
| }, | ||
| "description": "SpotPlacementScores object supplied in the body of the Post spot placement scores operation." | ||
| } | ||
| ], | ||
| "responses": { | ||
| "200": { | ||
| "description": "Success", | ||
| "schema": { | ||
| "$ref": "#/definitions/SpotPlacementScoresResponse" | ||
| } | ||
| }, | ||
| "default": { | ||
| "description": "Error response describing why the operation failed.", | ||
| "schema": { | ||
| "$ref": "../../../../../../common-types/resource-management/v3/types.json#/definitions/ErrorResponse" | ||
| } | ||
| } | ||
| }, | ||
| "x-ms-examples": { | ||
| "Returns spot VM placement scores for given configurations.": { | ||
| "$ref": "./examples/GenerateSpotPlacementScores.json" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "definitions": { | ||
| "ComputeDiagnosticBase": { | ||
| "description": "Contains metadata of a diagnostic type", | ||
| "type": "object", | ||
| "properties": { | ||
| "properties": { | ||
| "$ref": "#/definitions/DiagnosticProperties" | ||
| } | ||
| }, | ||
| "allOf": [ | ||
| { | ||
| "$ref": "../../../../../../common-types/resource-management/v3/types.json#/definitions/ProxyResource" | ||
| } | ||
| ] | ||
| }, | ||
| "DiagnosticProperties": { | ||
| "description": "Contains additional properties of a diagnostic", | ||
| "type": "object", | ||
| "properties": { | ||
| "supportedResourceTypes": { | ||
| "type": "array", | ||
| "items": { | ||
| "type": "string" | ||
| }, | ||
| "description": "Describes what are the supported resource types for a diagnostic." | ||
| } | ||
| } | ||
| }, | ||
| "SpotPlacementScoresInput": { | ||
| "type": "object", | ||
| "properties": { | ||
| "desiredLocations": { | ||
| "type": "array", | ||
| "items": { | ||
| "type": "string" | ||
| }, | ||
| "description": "The desired regions" | ||
| }, | ||
| "desiredSizes": { | ||
| "type": "array", | ||
| "items": { | ||
| "$ref": "#/definitions/ResourceSize" | ||
| }, | ||
| "description": "The desired virtual machine SKU sizes." | ||
| }, | ||
| "desiredCount": { | ||
| "type": "integer", | ||
| "format": "int32", | ||
| "description": "Desired instance count per region/zone based on the scope." | ||
| }, | ||
| "availabilityZones": { | ||
| "type": "boolean", | ||
| "description": "Defines if the scope is zonal or regional." | ||
| } | ||
| }, | ||
| "description": "SpotPlacementScores API Input." | ||
| }, | ||
| "SpotPlacementScoresResponse": { | ||
| "type": "object", | ||
| "properties": { | ||
| "desiredLocations": { | ||
| "type": "array", | ||
| "items": { | ||
| "type": "string" | ||
| }, | ||
| "description": "The desired regions" | ||
| }, | ||
| "desiredSizes": { | ||
| "type": "array", | ||
| "items": { | ||
| "$ref": "#/definitions/ResourceSize" | ||
| }, | ||
| "description": "The desired virtual machine SKU sizes." | ||
| }, | ||
| "desiredCount": { | ||
| "type": "integer", | ||
| "format": "int32", | ||
| "description": "Desired instance count per region/zone based on the scope." | ||
| }, | ||
| "availabilityZones": { | ||
| "type": "boolean", | ||
| "description": "Defines if the scope is zonal or regional." | ||
| }, | ||
| "placementScores": { | ||
| "type": "array", | ||
| "items": { | ||
| "$ref": "#/definitions/PlacementScore" | ||
| }, | ||
| "description": "A placement score indicating the likelihood of successfully allocating the specified Spot VM(s), as well as the expected lifetimes of the Spot VM(s) after allocation." | ||
| } | ||
| }, | ||
| "description": "SpotPlacementScores API response." | ||
| }, | ||
| "ResourceSize": { | ||
| "type": "object", | ||
| "properties": { | ||
| "sku": { | ||
| "type": "string", | ||
| "description": "The resource's CRP virtual machine SKU size." | ||
| } | ||
| }, | ||
| "description": "SpotPlacementRecommender API response." | ||
| }, | ||
| "PlacementScore": { | ||
| "type": "object", | ||
| "properties": { | ||
| "sku": { | ||
| "type": "string", | ||
| "description": "The resource's CRP virtual machine SKU size." | ||
| }, | ||
| "region": { | ||
| "type": "string", | ||
| "description": "The region." | ||
| }, | ||
| "availabilityZone": { | ||
| "type": "string", | ||
| "description": "The availability zone." | ||
| }, | ||
| "score": { | ||
| "type": "string", | ||
| "description": "A placement score indicating the likelihood of successfully allocating the specified Spot VM(s), as well as the expected lifetimes of the Spot VM(s) after allocation." | ||
| }, | ||
| "isQuotaAvailable": { | ||
| "type": "boolean", | ||
| "description": "Whether the desired quota is available." | ||
| } | ||
| }, | ||
| "description": "The spot placement score for sku/region/zone combination." | ||
| } | ||
| } | ||
| } | ||
85 changes: 85 additions & 0 deletions
85
...icrosoft.Compute/DiagnosticRP/stable/2025-06-05/examples/GenerateSpotPlacementScores.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "00000000-0000-0000-0000-000000000000", | ||
| "location": "eastus", | ||
| "api-version": "2025-06-05", | ||
| "spotPlacementScoresInput": { | ||
| "desiredLocations": [ | ||
| "eastus", | ||
| "eastus2" | ||
| ], | ||
| "desiredSizes": [ | ||
| { | ||
| "sku": "Standard_D2_v2" | ||
| } | ||
| ], | ||
| "desiredCount": 1, | ||
| "availabilityZones": true | ||
| } | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "desiredLocations": [ | ||
| "eastus", | ||
| "eastus2" | ||
| ], | ||
| "desiredSizes": [ | ||
| { | ||
| "sku": "Standard_D2_v2" | ||
| } | ||
| ], | ||
| "desiredCount": 1, | ||
| "availabilityZones": true, | ||
| "placementScores": [ | ||
| { | ||
| "sku": "Standard_D2_v2", | ||
| "region": "eastus", | ||
| "availabilityZone": "1", | ||
| "score": "High", | ||
| "isQuotaAvailable": true | ||
| }, | ||
| { | ||
| "sku": "Standard_D2_v2", | ||
| "region": "eastus", | ||
| "availabilityZone": "2", | ||
| "score": "High", | ||
| "isQuotaAvailable": true | ||
| }, | ||
| { | ||
| "sku": "Standard_D2_v2", | ||
| "region": "eastus", | ||
| "availabilityZone": "3", | ||
| "score": "High", | ||
| "isQuotaAvailable": true | ||
| }, | ||
| { | ||
| "sku": "Standard_D2_v2", | ||
| "region": "eastus2", | ||
| "availabilityZone": "1", | ||
| "score": "DataNotFoundOrStale", | ||
| "isQuotaAvailable": true | ||
| }, | ||
| { | ||
| "sku": "Standard_D2_v2", | ||
| "region": "eastus2", | ||
| "availabilityZone": "2", | ||
| "score": "High", | ||
| "isQuotaAvailable": true | ||
| }, | ||
| { | ||
| "sku": "Standard_D2_v2", | ||
| "region": "eastus2", | ||
| "availabilityZone": "3", | ||
| "score": "High", | ||
| "isQuotaAvailable": true | ||
| } | ||
| ] | ||
| }, | ||
| "headers": { | ||
| "x-ms-request-id": "12345678-1234-1234-1234-123456789abc", | ||
| "location": "https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Compute/locations/eastus/placementScores/spot/generate?api-version=2025-06-05" | ||
| } | ||
| } | ||
| } | ||
| } |
24 changes: 24 additions & 0 deletions
24
...ger/Microsoft.Compute/DiagnosticRP/stable/2025-06-05/examples/GetSpotPlacementScores.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "00000000-0000-0000-0000-000000000000", | ||
| "location": "eastus", | ||
| "api-version": "2025-06-05" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "headers": { | ||
| "x-ms-request-id": "12345678-1234-1234-1234-123456789abc" | ||
| }, | ||
| "body": { | ||
| "id": "/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Compute/placementScores/spot?api-version=2025-06-05", | ||
| "name": "spotPlacementScores", | ||
| "type": "Microsoft.Compute/placementScores", | ||
| "properties": { | ||
| "supportedResourceTypes": [ | ||
| "Microsoft.Compute/virtualMachines" | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are multiple APIs in previous preview version that are missed here
https://github.com/Azure/azure-rest-api-specs/blob/main/specification/compute/resource-manager/Microsoft.Compute/DiagnosticRP/preview/2025-02-01-preview/diagnostic.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Ramoka, those other APIs will remain as 2025-02-01-preview version. The only APIs that we would like to expose using 2025-06-05 API version are the Spot placement score APIs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR was also previously approved by ARM PR review team: #34340
I have reopened it as the last PR was closed due to inactivity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ARMSignoff was added on May 1, but there are commits that went in after the sign off, which are not reviewed and the PR is closed due to inactivity. I am not sure if we should take the previous PR's approval as there are changes are were not reviewed.
That being said, skipping APIs when incrementing API versions, is not the standard pattern or guidelines either.
New API versions should have all the existing APIs + any new changes coming fresh in the new API version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making this chain visible for other reviewers, as commenting in place is not showing up down below.