Skip to content

Update CODEOWNERS#3540

Merged
annatisch merged 1 commit intomasterfrom
sergey-shandar-patch-2
Jul 30, 2018
Merged

Update CODEOWNERS#3540
annatisch merged 1 commit intomasterfrom
sergey-shandar-patch-2

Conversation

@sergey-shandar
Copy link
Contributor

@sergey-shandar sergey-shandar commented Jul 30, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@sergey-shandar sergey-shandar requested a review from felixwa July 30, 2018 17:17
@AutorestCI
Copy link

AutorestCI commented Jul 30, 2018

Automation for azure-sdk-for-go

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Jul 30, 2018

Automation for azure-sdk-for-python

Unable to detect any generation context from this PR.

@sergey-shandar
Copy link
Contributor Author

@annatisch please, merge it after @felixwa approval.

Copy link
Contributor

@felixwa felixwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@annatisch annatisch merged commit 7614c32 into master Jul 30, 2018
@AutorestCI
Copy link

AutorestCI commented Jul 30, 2018

Automation for azure-sdk-for-node

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Jul 30, 2018

Automation for azure-sdk-for-ruby

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Jul 30, 2018

Automation for azure-sdk-for-java

Unable to detect any generation context from this PR.

@sergey-shandar sergey-shandar deleted the sergey-shandar-patch-2 branch September 12, 2018 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants