[Cognitive Services] Update endpoint URL template for Content Moderator.#3505
[Cognitive Services] Update endpoint URL template for Content Moderator.#3505jhendrixMSFT merged 2 commits intomasterfrom unknown repository
Conversation
There was a problem hiding this comment.
Remove this to keep consistency
There was a problem hiding this comment.
Remove the outdated region list.
Automation for azure-sdk-for-javaThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-rubyThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-nodeA PR has been created for you: |
|
@yangyuan are we still waiting for other reviewers? |
|
Can one of the admins verify this patch? |
|
Hi @jhendrixMSFT. I've updated some SDKs, but heard some negative feedback (also found a small issue in auto-generated documents). |
|
@yangyuan @jhendrixMSFT, I am good with these. @swiftarrow11, how about you? |
jhendrixMSFT
left a comment
There was a problem hiding this comment.
There are some model validation failures that need to be addressed, please see the travis log.
|
hi @jhendrixMSFT, I've fixed the model validation error. It shows that Linter Diff complaints some operations missing x-ms-examples.
|
|
@bsiegel I understand you're working on this new linter diff in CI? I don't think it should be failing for this PR as it doesn't add any new operations. |
|
@veronicagg do you know about this new linter behavior? |
|
@jhendrixMSFT I asked @bsiegel about this in the morning. @bsiegel I think this is another case for the issue you fixed earlier today, in which case this branch would need to be rebased to pick up Brandon's fix. @bsiegel could you check other PRs that may be opened and got affected by it? |
|
@jhendrixMSFT I have rebase the branch and now all passes. :) |
jhendrixMSFT
left a comment
There was a problem hiding this comment.
There are some model validation failures that need to be addressed, please see the travis log.
Detail background and explainations in here: #3489 Cognitive Services URL template (endpoint)
Please hold for swiftarrow11 or sanjeev3's review as well as my confirmation.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger