Merged
Conversation
Next Steps to MergeNext steps that must be taken to merge this PR:
|
|
PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
danieljurek
commented
May 30, 2025
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
c06429d to
2d59390
Compare
mikeharder
reviewed
Jul 12, 2025
mikeharder
reviewed
Jul 12, 2025
mikeharder
reviewed
Jul 12, 2025
mikeharder
reviewed
Jul 12, 2025
mikeharder
reviewed
Jul 12, 2025
Co-authored-by: Mike Harder <mharder@microsoft.com>
…ing the filesystem directly
mikeharder
reviewed
Jul 24, 2025
Co-authored-by: Mike Harder <mharder@microsoft.com>
mikeharder
approved these changes
Jul 24, 2025
Member
Author
|
This can merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate API Doc Preview to Azure DevOps pipeline that invokes a pipeline in the docs org, waits for the pipeline to finish, then report status via a commit status:
The commit status is updated as relevant things happen in the orchestration pipeline. Commit statuses are not check statuses so they may not work for required pipelines. At this point docs is not a required check so this is not a hindrance.
It is possible to set check statuses, but those aggregate to check suites in "strange" ways in the GitHub UI and so are not advisable because they can cause confusion.
Tests
Success
Sample build: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5078254&view=logs&j=407c8e09-36f7-5b0b-5ef1-9a46f011447b&t=b7bb9f89-2346-5516-09dd-ff209e5433c8
Sample docs build: https://dev.azure.com/apidrop/Content%20CI/_build/results?buildId=551536&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b
Docs preview: https://review.learn.microsoft.com/en-us/rest/api/azure-rest-preview/?branch=preview%2FAzure%2Fazure-rest-api-specs%2Fpr%2F35018%2Fbuild%2F5078254%2Fattempt%2F1&view=azure-rest-preview
Orchestration pipeline failure
Sample build: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5078190&view=logs&j=407c8e09-36f7-5b0b-5ef1-9a46f011447b
Docs pipeline failure
Sample build: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5078217&view=logs&j=407c8e09-36f7-5b0b-5ef1-9a46f011447b
Corresponding docs build: https://dev.azure.com/apidrop/Content%20CI/_build/results?buildId=551533&view=results
Timeout
Looking over history about 10% of runs last longer than 9 minutes which could put us close to a 10 minute timeout for the
AzureCLI@2token.I initially thought timeout could be tested by finding a spec that took a "long time" time to build in another pipeline run. That did not prove to be the case. Time variation appears to depend on other factors.
To test timeout, I added code to throw an exception in
api-doc-preview-wait.mjsafter 3 minutes. This way the script would "timeout" and fail and the pipeline task'sretryCountOnTaskFailurewould kick in and retry the task.Example pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5078095&view=logs&j=407c8e09-36f7-5b0b-5ef1-9a46f011447b&t=b7bb9f89-2346-5516-09dd-ff209e5433c8
The log shows the script failing,
AzureCLI@2re-authorizing and then continuing: