Enabled required for go and python data plane cases

eng/pipelines/spec-gen-sdk.yml

@@ -1,3 +1,3 @@
 parameters:
   - name: SdkRepoCommit
     type: string
@@ -31,10 +31,6 @@
     displayName: 'Skip SDK pull request creation'
 
 trigger: none
-pr:
-  paths: 
-    include:
-      - specification/**
 
 extends:
   template: /eng/pipelines/templates/stages/archetype-spec-gen-sdk.yml

eng/tools/spec-gen-sdk-runner/src/command-helpers.ts

@@ -1,3 +1,3 @@
 import fs from "node:fs";
 import path from "node:path";
 import { fileURLToPath } from "node:url";
@@ -283,6 +283,9 @@
  * @param breakingChangeLabel - The breaking change label.
  * @param hasBreakingChange - A flag indicating whether there are breaking changes.
  * @param hasManagementPlaneSpecs - A flag indicating whether there are management plane specs.
+ * @param stagedArtifactsFolder - The staged artifacts folder.
+ * @param apiViewRequestData - The API view request data.
+ * @param sdkGenerationExecuted - A flag indicating whether the SDK generation was executed.
  * @returns the run status code.
  */
 export function generateArtifact(
@@ -293,6 +296,7 @@
   hasManagementPlaneSpecs: boolean,
   stagedArtifactsFolder: string,
   apiViewRequestData: APIViewRequestData[],
+  sdkGenerationExecuted: boolean = true,
 ): number {
   const specGenSdkArtifactName = "spec-gen-sdk-artifact";
   const specGenSdkArtifactFileName = specGenSdkArtifactName + ".json";
@@ -305,13 +309,20 @@
     if (!fs.existsSync(specGenSdkArtifactAbsoluteFolder)) {
       fs.mkdirSync(specGenSdkArtifactAbsoluteFolder, { recursive: true });
     }
+    let isSpecGenSdkCheckRequired = false;
+    if (sdkGenerationExecuted) {
+      isSpecGenSdkCheckRequired = getRequiredSettingValue(
+        hasManagementPlaneSpecs,
+        commandInput.sdkLanguage as SdkName,
+      );
+    }
+
     // Write artifact
     const artifactInfo: SpecGenSdkArtifactInfo = {
       language: commandInput.sdkLanguage,
       result,
       labelAction: hasBreakingChange,
-      isSpecGenSdkCheckRequired:
-        hasManagementPlaneSpecs && SpecGenSdkRequiredSettings[commandInput.sdkLanguage as SdkName],
+      isSpecGenSdkCheckRequired,
       apiViewRequestData: apiViewRequestData,
     };
     fs.writeFileSync(
@@ -348,3 +359,20 @@
   }
   return specConfigPath;
 }
+
+/**
+ * Get the required setting value for the SDK check based on the spec PR types.
+ * @param hasManagementPlaneSpecs - A flag indicating whether there are management plane specs.
+ * @param sdkName - The SDK name.
+ * @returns boolean indicating whether the SDK check is required.
+ */
+export function getRequiredSettingValue(
+  hasManagementPlaneSpecs: boolean,
+  sdkName: SdkName,
+): boolean {
+  if (hasManagementPlaneSpecs) {
+    return SpecGenSdkRequiredSettings[sdkName].managementPlane;
+  } else {
+    return SpecGenSdkRequiredSettings[sdkName].dataPlane;
+  }
+}

eng/tools/spec-gen-sdk-runner/src/commands.ts

@@ -1,3 +1,3 @@
 import fs from "node:fs";
 import path from "node:path";
 import { runSpecGenSdkCommand, resetGitRepo, SpecConfigs } from "./utils.js";
@@ -90,11 +90,17 @@
   let hasManagementPlaneSpecs = false;
   let overallRunHasBreakingChange = false;
   let currentRunHasBreakingChange = false;
+  let sdkGenerationExecuted = true;
   let overallExecutionResult = "";
   let currentExecutionResult = "";
   let stagedArtifactsFolder = "";
   const apiViewRequestData: APIViewRequestData[] = [];
 
+  if (changedSpecs.length === 0) {
+    sdkGenerationExecuted = false;
+    overallExecutionResult = "succeeded";
+  }
+
   for (const changedSpec of changedSpecs) {
     if (!changedSpec.typespecProject && !changedSpec.readmeMd) {
       logMessage("Runner: no spec config file found in the changed files", LogLevel.Warn);
@@ -179,6 +185,7 @@
       hasManagementPlaneSpecs,
       stagedArtifactsFolder,
       apiViewRequestData,
+      sdkGenerationExecuted,
     ) || statusCode;
   return statusCode;
 }

eng/tools/spec-gen-sdk-runner/src/spec-helpers.ts

@@ -1,3 +1,3 @@
 import path from "node:path";
 import {
   getChangedFiles,
@@ -31,6 +31,10 @@
     .filter((p) => p.startsWith("specification/"))
     .filter((p) => !p.includes("/scenarios/"));
 
+  if (fileList.length === 0) {
+    logMessage("No relevant files changed under 'specification' folder in the PR");
+    return [];
+  }
   logMessage(`Related readme.md and typespec project list:`);
   const changedSpecs: ChangedSpecs[] = [];
 

eng/tools/spec-gen-sdk-runner/src/types.ts

@@ -1,3 +1,3 @@
 /**
  * Represents the input parameters required for spec-gen-sdk command execution.
  */
@@ -46,7 +46,7 @@
   result: string;
   labelAction?: boolean;
   isSpecGenSdkCheckRequired: boolean;
-  apiViewRequestData: APIViewRequestData [];
+  apiViewRequestData: APIViewRequestData[];
 }
 
 /**
@@ -59,13 +59,43 @@
   | "azure-sdk-for-net"
   | "azure-sdk-for-python";
 
+/**
+ * Represents the plane types for SDK generation settings
+ */
+export interface PlaneTypeSettings {
+  /**
+   * Whether spec-gen-sdk check is required for data plane
+   */
+  dataPlane: boolean;
+
+  /**
+   * Whether spec-gen-sdk check is required for management plane
+   */
+  managementPlane: boolean;
+}
+
 /**
  * Required check settings for all languages.
  */
-export const SpecGenSdkRequiredSettings: Record<SdkName, boolean> = {
-  "azure-sdk-for-go": true,
-  "azure-sdk-for-java": true,
-  "azure-sdk-for-js": false,
-  "azure-sdk-for-net": false,
-  "azure-sdk-for-python": true,
+export const SpecGenSdkRequiredSettings: Record<SdkName, PlaneTypeSettings> = {
+  "azure-sdk-for-go": {
+    dataPlane: true,
+    managementPlane: true,
+  },
+  "azure-sdk-for-java": {
+    dataPlane: false,
+    managementPlane: true,
+  },
+  "azure-sdk-for-js": {
+    dataPlane: false,
+    managementPlane: false,
+  },
+  "azure-sdk-for-net": {
+    dataPlane: false,
+    managementPlane: false,
+  },
+  "azure-sdk-for-python": {
+    dataPlane: true,
+    managementPlane: true,
+  },
 };