ComputerVision: bug fixes for /describe and /analyze [breaking]#3486
Merged
sergey-shandar merged 1 commit intoAzure:masterfrom Jul 30, 2018
Merged
Conversation
* Inconsistent argument type for `/analyze?details=...` between URL and stream methods * BingIU imagetype return values needs to be integral * Description `maxCandidates` argument needs to be integral
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-nodeThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-javaThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-rubyThe initial PR has been merged into your service PR: |
Contributor
Author
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
Contributor
|
@DavidLiCIG @felixwa please, review. The PR contains potential SDK and API breaking changes, it's important that we receive approval from you. |
sergey-shandar
approved these changes
Jul 27, 2018
Contributor
yangyuan
approved these changes
Jul 27, 2018
| @@ -232,9 +232,9 @@ | |||
| "name": "maxCandidates", | |||
Contributor
|
@sergey-shandar, this looks good to me. In future please include @yangyuan as reviewer for all Cognitive Services swagger file review. Thanks! |
9 tasks
cthrash
added a commit
to cthrash/azure-sdk-for-net
that referenced
this pull request
Jul 31, 2018
Updates for [PR1](Azure/azure-rest-api-specs#3479) and [PR2](Azure/azure-rest-api-specs#3486). * The API client name was changed from ComputerVisionAPI to ComputerVisionClient, in keeping with other Azure SDKs. * The way the Azure region is specfied has changed. Specifically, the AzureRegion property was dropped in favor of an Endpoint property. If you were previously specifying an AzureRegion value, you should now specify Endpoint='https://{AzureRegion}.api.cognitive.microsoft.com' instead. This change ensures better global coverage. * Some inconsistencies in argument types were corrected. (a) maxCandidate is an integer for DescribeImage. (b) details is a array of enumerated types for AnalyzeImage. (c) isBWImg in the AnalyzeImage(color) response is a non-nullable bool. (d) clipArtType/lineDrawing in AnalyzeImage(imageType) is an integer (index) instead of a double.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/analyze?details=...between URL and stream methodsmaxCandidatesargument needs to be integralThis checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger