Skip to content

Security Center - Removing properties to allow auto code generation#3453

Merged
hovsepm merged 2 commits intoAzure:masterfrom
chlahav:master
Jul 24, 2018
Merged

Security Center - Removing properties to allow auto code generation#3453
hovsepm merged 2 commits intoAzure:masterfrom
chlahav:master

Conversation

@chlahav
Copy link
Copy Markdown
Contributor

@chlahav chlahav commented Jul 19, 2018 •
edited by azuresdkci
Loading

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jul 19, 2018 •
edited
Loading

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@azuresdkci azuresdkci requested a review from hovsepm July 19, 2018 17:50
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jul 19, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jul 19, 2018 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#2298

@chlahav chlahav force-pushed the master branch 3 times, most recently from c3d03a6 to 91612b8 Compare July 19, 2018 18:28
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jul 19, 2018 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jul 19, 2018 •
edited
Loading

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@chlahav chlahav force-pushed the master branch 3 times, most recently from 0aa3041 to 05918de Compare July 19, 2018 19:16
@chlahav chlahav mentioned this pull request Jul 22, 2018
Closed
@chlahav chlahav force-pushed the master branch 2 times, most recently from 690abf6 to 108adbf Compare July 23, 2018 17:53
@chlahav chlahav changed the title Security Cetner - Removing properties to allow auto code generation Security Center - Removing properties to allow auto code generation Jul 23, 2018
Fix for allOf and case mismatch in property name
4db1d68 
- make allOf on `object` not a `string`
- fix hostname to match examples
@vladbarosan vladbarosan mentioned this pull request Jul 24, 2018
Merged
@vladbarosan
Copy link
Copy Markdown

vladbarosan commented Jul 24, 2018

@AutorestCI rebuild azure-sdk-for-go

@AutorestCI AutorestCI mentioned this pull request Jul 24, 2018
Merged
@chlahav
Copy link
Copy Markdown
Contributor Author

chlahav commented Jul 24, 2018

thanks @vladbarosan.
I confirm that:

  1. “hostname” is the correct property name
  2. the “additionalProperties” was supposed to be removed

@hovsepm hovsepm merged commit 30d7f17 into Azure:master Jul 24, 2018
@vladbarosan
Copy link
Copy Markdown

vladbarosan commented Jul 25, 2018

@AutorestCI rebuild azure-sdk-for-go

@AutorestCI AutorestCI mentioned this pull request Jul 25, 2018
Merged
@vladbarosan
Copy link
Copy Markdown

vladbarosan commented Jul 25, 2018

@AutorestCI rebuild azure-sdk-for-go

@AutorestCI AutorestCI mentioned this pull request Jul 25, 2018
Merged
@vladbarosan
Copy link
Copy Markdown

vladbarosan commented Jul 25, 2018

@lmazuel so if you can help a little here. I updated Go generator version in the "latest" branch in the sdk repo. When executing again the rebuild command, should it use the new version there ? And are there any logs to see the build process ?

@jhendrixMSFT
Copy link
Copy Markdown
Member

jhendrixMSFT commented Jul 25, 2018

@vladbarosan I think "regenerate" is the command you want but let's see what @lmazuel has to say.

@vladbarosan
Copy link
Copy Markdown

vladbarosan commented Jul 25, 2018

@AutorestCI regenerate azure-sdk-for-go

@vladbarosan
Copy link
Copy Markdown

vladbarosan commented Jul 25, 2018

@jhendrixMSFT it gave me a thumbs up so lets see :)

@AutorestCI AutorestCI mentioned this pull request Jul 25, 2018
Merged
@vladbarosan
Copy link
Copy Markdown

vladbarosan commented Jul 25, 2018

didnt see to help :(, any suggestions @lmazuel ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hovsepm hovsepm hovsepm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hovsepm hovsepm

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@chlahav @AutorestCI @vladbarosan @jhendrixMSFT @hovsepm