Skip to content

Usesr/singankit/evaluation review feedback #34427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
singankit merged 3 commits into from
May 2, 2025
Merged

Usesr/singankit/evaluation review feedback #34427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bbb3927
Fixing review comments
singankit May 2, 2025
aa0da2d
Evaluation Review Commnets fixed
singankit May 2, 2025
6fcafa8
Reverting non required change
singankit May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion specification/ai/Azure.AI.Projects/evaluations/routes.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ interface Evaluations {
@doc("Creates an evaluation run.")
@route("runs:run")
@post
createRun is Azure.Core.Foundations.Operation<
create is Azure.Core.Foundations.Operation<
{
@doc("Evaluation to be run")
@body
Expand Down
4 changes: 2 additions & 2 deletions ...Evaluations_CreateRun_MaximumSet_Gen.json → ...ew/Evaluations_Create_MaximumSet_Gen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"title": "Evaluations_CreateRun_MaximumSet",
"operationId": "Evaluations_CreateRun",
"title": "Evaluations_Create_MaximumSet",
"operationId": "Evaluations_Create",
"parameters": {
"api-version": "2025-05-15-preview",
"evaluation": {
Expand Down
0 ...Evaluations_CreateRun_MinimumSet_Gen.json → ...ew/Evaluations_Create_MinimumSet_Gen.json
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions ...es/RedTeams_CreateRun_MaximumSet_Gen.json → ...eview/RedTeams_Create_MaximumSet_Gen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"title": "RedTeams_CreateRun_MaximumSet",
"operationId": "RedTeams_CreateRun",
"title": "RedTeams_Create_MaximumSet",
"operationId": "RedTeams_Create",
"parameters": {
"api-version": "2025-05-15-preview",
"RedTeam": {
Expand Down
4 changes: 2 additions & 2 deletions ...ew/RedTeams_CreateRun_MinimumSet_Gen.json → ...eview/RedTeams_Create_MinimumSet_Gen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"title": "RedTeams_CreateRun_MinimumSet",
"operationId": "RedTeams_CreateRun",
"title": "RedTeams_Create_MinimumSet",
"operationId": "RedTeams_Create",
"parameters": {
"api-version": "2025-05-15-preview",
"RedTeam": {
Expand Down
3 changes: 2 additions & 1 deletion specification/ai/Azure.AI.Projects/red-teams/models.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,8 +140,9 @@ model TargetConfig {
model RedTeam {
@doc("Identifier of the red team.")
@key("name")
@encodedName("application/json", "id")
@visibility(Lifecycle.Read)
id: string;
name: string;

@doc("Name of the red-team scan.")
scanName?: string;
Expand Down
2 changes: 1 addition & 1 deletion specification/ai/Azure.AI.Projects/red-teams/routes.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ interface RedTeams {
@doc("Creates a redteam run.")
@route("runs:run")
@post
createRun is Azure.Core.Foundations.Operation<
create is Azure.Core.Foundations.Operation<
{
@doc("Redteam to be run")
@body
Expand Down
26 changes: 14 additions & 12 deletions ...ication/ai/data-plane/Azure.AI.Projects/preview/2025-05-15-preview/azure-ai-projects.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -947,7 +947,7 @@
},
"/evaluations/runs:run": {
"post": {
"operationId": "Evaluations_CreateRun",
"operationId": "Evaluations_Create",
"description": "Creates an evaluation run.",
"parameters": [
{
Expand Down Expand Up @@ -984,11 +984,11 @@
}
},
"x-ms-examples": {
"Evaluations_CreateRun_MaximumSet": {
"$ref": "./examples/Evaluations_CreateRun_MaximumSet_Gen.json"
"Evaluations_Create_MaximumSet": {
"$ref": "./examples/Evaluations_Create_MaximumSet_Gen.json"
},
"Evaluations_CreateRun_MinimumSet": {
"$ref": "./examples/Evaluations_CreateRun_MinimumSet_Gen.json"
"Evaluations_Create_MinimumSet": {
"$ref": "./examples/Evaluations_Create_MinimumSet_Gen.json"
}
}
}
Expand Down Expand Up @@ -1426,7 +1426,7 @@
},
"/redTeams/runs:run": {
"post": {
"operationId": "RedTeams_CreateRun",
"operationId": "RedTeams_Create",
"description": "Creates a redteam run.",
"parameters": [
{
Expand Down Expand Up @@ -1463,11 +1463,11 @@
}
},
"x-ms-examples": {
"RedTeams_CreateRun_MaximumSet": {
"$ref": "./examples/RedTeams_CreateRun_MaximumSet_Gen.json"
"RedTeams_Create_MaximumSet": {
"$ref": "./examples/RedTeams_Create_MaximumSet_Gen.json"
},
"RedTeams_CreateRun_MinimumSet": {
"$ref": "./examples/RedTeams_CreateRun_MinimumSet_Gen.json"
"RedTeams_Create_MinimumSet": {
"$ref": "./examples/RedTeams_Create_MinimumSet_Gen.json"
}
}
}
Expand Down Expand Up @@ -2878,7 +2878,8 @@
"description": "The RedTeam items on this page",
"items": {
"$ref": "#/definitions/RedTeam"
}
},
"x-ms-identifiers": []
},
"nextLink": {
"type": "string",
Expand Down Expand Up @@ -2999,7 +3000,8 @@
"id": {
"type": "string",
"description": "Identifier of the red team.",
"readOnly": true
"readOnly": true,
"x-ms-client-name": "name"
},
"scanName": {
"type": "string",
Expand Down
4 changes: 2 additions & 2 deletions ...Evaluations_CreateRun_MaximumSet_Gen.json → ...es/Evaluations_Create_MaximumSet_Gen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"title": "Evaluations_CreateRun_MaximumSet",
"operationId": "Evaluations_CreateRun",
"title": "Evaluations_Create_MaximumSet",
"operationId": "Evaluations_Create",
"parameters": {
"api-version": "2025-05-15-preview",
"evaluation": {
Expand Down
0 ...Evaluations_CreateRun_MinimumSet_Gen.json → ...es/Evaluations_Create_MinimumSet_Gen.json
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions ...ew/RedTeams_CreateRun_MaximumSet_Gen.json → ...mples/RedTeams_Create_MaximumSet_Gen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"title": "RedTeams_CreateRun_MaximumSet",
"operationId": "RedTeams_CreateRun",
"title": "RedTeams_Create_MaximumSet",
"operationId": "RedTeams_Create",
"parameters": {
"api-version": "2025-05-15-preview",
"RedTeam": {
Expand Down
4 changes: 2 additions & 2 deletions ...es/RedTeams_CreateRun_MinimumSet_Gen.json → ...mples/RedTeams_Create_MinimumSet_Gen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"title": "RedTeams_CreateRun_MinimumSet",
"operationId": "RedTeams_CreateRun",
"title": "RedTeams_Create_MinimumSet",
"operationId": "RedTeams_Create",
"parameters": {
"api-version": "2025-05-15-preview",
"RedTeam": {
Expand Down
Loading