Skip to content

Security Center: Fixing documentation of auto-provision settings #3429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsgouda merged 1 commit into from
Jul 18, 2018
Merged

Security Center: Fixing documentation of auto-provision settings #3429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...examples/AutoProvisioningSettings/CreateAutoProvisioningSettingsSubscription_example.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"name": "default",
"type": "Microsoft.Security/autoProvisioningSettings",
"properties": {
"provisioningSetting": "Automatic"
Copy link
Contributor

@dsgouda dsgouda Jul 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: _example for the file name unnecessarily increases the file path size, you could simply rename this as CreateAutoProvisioningSettingsSubscription.json
not a blocker

Copy link
Contributor Author

@chlahav chlahav Jul 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have simultaneous PRs on this repo, in order to avoid conflicts we will change it after they will be completed 😄

"autoProvision": "On"
}
}
},
Expand All @@ -19,7 +19,7 @@
"name": "default",
"type": "Microsoft.Security/autoProvisioningSettings",
"properties": {
"provisioningSetting": "Automatic"
"autoProvision": "On"
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion ...iew/examples/AutoProvisioningSettings/GetAutoProvisioningSettingSubscription_example.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"name": "default",
"type": "Microsoft.Security/autoProvisioningSettings",
"properties": {
"provisioningSetting": "Automatic"
"autoProvision": "On"
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion ...ew/examples/AutoProvisioningSettings/GetAutoProvisioningSettingsSubscription_example.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"name": "default",
"type": "Microsoft.Security/autoProvisioningSettings",
"properties": {
"provisioningSetting": "Automatic"
"autoProvision": "On"
}
}]
}
Expand Down
10 changes: 5 additions & 5 deletions ...ion/security/resource-manager/Microsoft.Security/preview/2017-08-01-preview/security.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1020,15 +1020,15 @@
"type": "object",
"description": "describes properties of an auto provisioning setting",
"properties": {
"provisioningSetting": {
"autoProvision": {
"type": "string",
"description": "Describes what kind of security agent provisioning action to take",
"enum": ["Automatic", "Off"],
"enum": ["On", "Off"],
"x-ms-enum": {
"name": "provisioningSetting",
Copy link
Contributor

@dsgouda dsgouda Jul 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please acknowledge that this will be a breaking change in the SDKs generated

Copy link
Contributor Author

@chlahav chlahav Jul 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we acknowledge

"name": "autoProvision",
"modelAsString": true,
"values": [{
"value": "Automatic",
"value": "On",
"description": "Install missing security agent on VMs automatically"
},
{
Expand All @@ -1040,7 +1040,7 @@
}
},
"required": [
"provisioningSetting"
"autoProvision"
]
},
"ComplianceList": {
Expand Down