Skip to content

[EG] Readonly arrays#34182

Merged
lmazuel merged 6 commits intoAzure:mainfrom
l0lawrence:readonly_arrays
Apr 23, 2025
Merged

[EG] Readonly arrays#34182
lmazuel merged 6 commits intoAzure:mainfrom
l0lawrence:readonly_arrays

Conversation

@l0lawrence
Copy link
Copy Markdown
Member

@l0lawrence l0lawrence commented Apr 23, 2025 •
edited
Loading

something happening with tspconfig

@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app bot commented Apr 23, 2025 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR targets either the main branch of the public specs repo or the RPSaaSMaster branch of the private specs repo. These branches are not intended for iterative development. Therefore, you must acknowledge you understand that after this PR is merged, the APIs are considered shipped to Azure customers. Any further attempts at in-place modifications to the APIs will be subject to Azure's versioning and breaking change policies. Additionally, for control plane APIs, you must acknowledge that you are following all the best practices documented by ARM at aka.ms/armapibestpractices. If you do intend to release the APIs to your customers by merging this PR, add the PublishToCustomers label to your PR in acknowledgement of the above. Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR has at least one breaking change (label: BreakingChangeReviewRequired).
    To unblock this PR, follow the process at aka.ms/brch.
  • ❌ The required check named Swagger ModelValidation has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app bot commented Apr 23, 2025 •
edited
Loading

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 23, 2025 •
edited
Loading

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger Microsoft.ApiCenter
TypeSpec Microsoft.EventGrid.SystemEvents
Go sdk/messaging/eventgrid/azsystemevents

@azure-sdk azure-sdk mentioned this pull request Apr 23, 2025
Closed
@AzureRestAPISpecReview AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required data-plane TypeSpec Authored with TypeSpec labels Apr 23, 2025
This was referenced Apr 23, 2025
Closed
Closed
Closed
l0lawrence
l0lawrence commented Apr 23, 2025
View reviewed changes
...cation/eventgrid/data-plane/Microsoft.EventGrid/stable/2018-01-01/GeneratedSystemEvents.json
},
"required": [
"innererror",
"details"
Copy link
Copy Markdown
Member Author

@l0lawrence l0lawrence Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this changing names

Copy link
Copy Markdown
Member

@JoshLove-msft JoshLove-msft Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange..

Copy link
Copy Markdown
Member

@JoshLove-msft JoshLove-msft Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we are applying a rename and the new decorator is somehow preventing the rename from working.

Copy link
Copy Markdown
Member

@JoshLove-msft JoshLove-msft Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look like this is being renamed in propertyNameOverride. But the currently generated name is correct. I wonder if the old version was manually modified.

@JoshLove-msft JoshLove-msft mentioned this pull request Apr 23, 2025
Merged
@lmazuel lmazuel merged commit 548a102 into Azure:main Apr 23, 2025
42 of 47 checks passed
koen-mertens pushed a commit to koen-mertens/azure-rest-api-specs that referenced this pull request May 7, 2025
@l0lawrence @koen-mertens
[EG] Readonly arrays (Azure#34182)
7dc3727 
* update visibiltiy read

* read only

* add

* remove

* this
nwnt pushed a commit to nwnt/azure-rest-api-specs that referenced this pull request Jun 10, 2025
@l0lawrence
[EG] Readonly arrays (Azure#34182)
7fde020 
* update visibiltiy read

* read only

* add

* remove

* this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoshLove-msft JoshLove-msft JoshLove-msft approved these changes

@lmazuel lmazuel lmazuel approved these changes

@jsquire jsquire Awaiting requested review from jsquire

Assignees

No one assigned

Labels

BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required data-plane Event Grid TypeSpec Authored with TypeSpec

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@l0lawrence @lmazuel @JoshLove-msft @AzureRestAPISpecReview