Skip to content

Conversation

@melina5656
Copy link
Member

This PR contains two changes:

  1. Convert Swagger to TSP
  2. Fix diff after TSP generates swagger

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Apr 22, 2025

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR targets either the main branch of the public specs repo or the RPSaaSMaster branch of the private specs repo. These branches are not intended for iterative development. Therefore, you must acknowledge you understand that after this PR is merged, the APIs are considered shipped to Azure customers. Any further attempts at in-place modifications to the APIs will be subject to Azure's versioning and breaking change policies. Additionally, for control plane APIs, you must acknowledge that you are following all the best practices documented by ARM at aka.ms/armapibestpractices. If you do intend to release the APIs to your customers by merging this PR, add the PublishToCustomers label to your PR in acknowledgement of the above. Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR has at least one change violating Azure versioning policy (label: VersioningReviewRequired).
    To unblock this PR, either a) introduce a new API version with these changes instead of modifying an existing API version, or b) follow the process at aka.ms/brch.
  • ❌ The required check named TypeSpec Validation has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Apr 22, 2025

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@github-actions
Copy link

github-actions bot commented Apr 22, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger Microsoft.ExtendedLocation
TypeSpec Microsoft.ExtendedLocation
Go sdk/resourcemanager/extendedlocation/armextendedlocation
Python azure-mgmt-extendedlocation
Java com.azure.resourcemanager:azure-resourcemanager-extendedlocation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

resource-manager TypeSpec Authored with TypeSpec VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants